* [PATCH][NETNS]: Remove empty ->init callback.
@ 2008-04-21 15:04 Pavel Emelyanov
2008-04-21 21:33 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Pavel Emelyanov @ 2008-04-21 15:04 UTC (permalink / raw)
To: David Miller; +Cc: Linux Netdev List
The netns start-stop engine can happily live with any of
init or exit callbacks set to NULL.
Isn't it too late to merge this one?
Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
---
diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
index 8a0fd40..e591e09 100644
--- a/net/ipv6/addrconf.c
+++ b/net/ipv6/addrconf.c
@@ -4338,12 +4338,6 @@ int unregister_inet6addr_notifier(struct notifier_block *nb)
EXPORT_SYMBOL(unregister_inet6addr_notifier);
-
-static int addrconf_net_init(struct net *net)
-{
- return 0;
-}
-
static void addrconf_net_exit(struct net *net)
{
struct net_device *dev;
@@ -4360,7 +4354,6 @@ static void addrconf_net_exit(struct net *net)
}
static struct pernet_operations addrconf_net_ops = {
- .init = addrconf_net_init,
.exit = addrconf_net_exit,
};
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH][NETNS]: Remove empty ->init callback.
2008-04-21 15:04 [PATCH][NETNS]: Remove empty ->init callback Pavel Emelyanov
@ 2008-04-21 21:33 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2008-04-21 21:33 UTC (permalink / raw)
To: xemul; +Cc: netdev
From: Pavel Emelyanov <xemul@openvz.org>
Date: Mon, 21 Apr 2008 19:04:00 +0400
> The netns start-stop engine can happily live with any of
> init or exit callbacks set to NULL.
>
> Isn't it too late to merge this one?
No, it fixes the bug that extraneous kernel text space is
used by code that does nothing :-)
> Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
Applied, thanks Pavel.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-04-21 21:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-04-21 15:04 [PATCH][NETNS]: Remove empty ->init callback Pavel Emelyanov
2008-04-21 21:33 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).