netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH][NETFILTER]: Net namespace leak when reading /proc/net/xxx_tables_names.
@ 2008-04-21 14:52 Pavel Emelyanov
  2008-04-21 15:09 ` Patrick McHardy
  0 siblings, 1 reply; 2+ messages in thread
From: Pavel Emelyanov @ 2008-04-21 14:52 UTC (permalink / raw)
  To: David Miller, Linux Netdev List; +Cc: Patrick McHardy, Alexey Dobriyan

The seq_open_net() call should be accompanied with seq_release_net() one.

Signed-off-by: Pavel Emelyanov <xemul@openvz.org>

---

diff --git a/net/netfilter/x_tables.c b/net/netfilter/x_tables.c
index f52f7f8..11b22ab 100644
--- a/net/netfilter/x_tables.c
+++ b/net/netfilter/x_tables.c
@@ -787,7 +787,7 @@ static const struct file_operations xt_table_ops = {
 	.open	 = xt_table_open,
 	.read	 = seq_read,
 	.llseek	 = seq_lseek,
-	.release = seq_release,
+	.release = seq_release_net,
 };
 
 static void *xt_match_seq_start(struct seq_file *seq, loff_t *pos)

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH][NETFILTER]: Net namespace leak when reading /proc/net/xxx_tables_names.
  2008-04-21 14:52 [PATCH][NETFILTER]: Net namespace leak when reading /proc/net/xxx_tables_names Pavel Emelyanov
@ 2008-04-21 15:09 ` Patrick McHardy
  0 siblings, 0 replies; 2+ messages in thread
From: Patrick McHardy @ 2008-04-21 15:09 UTC (permalink / raw)
  To: Pavel Emelyanov
  Cc: David Miller, Linux Netdev List, Alexey Dobriyan,
	Netfilter Development Mailinglist

Pavel Emelyanov wrote:
> The seq_open_net() call should be accompanied with seq_release_net() one.
> 
> Signed-off-by: Pavel Emelyanov <xemul@openvz.org>

Applied, thanks.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-04-21 15:09 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-04-21 14:52 [PATCH][NETFILTER]: Net namespace leak when reading /proc/net/xxx_tables_names Pavel Emelyanov
2008-04-21 15:09 ` Patrick McHardy

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).