From: "Kok, Auke" <auke-jan.h.kok@intel.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Anton Titov <a.titov@host.bg>, Chris Snook <csnook@redhat.com>,
"H. Willstrand" <h.willstrand@gmail.com>,
netdev@vger.kernel.org,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] Re: Bad network performance over 2Gbps
Date: Mon, 21 Apr 2008 09:38:49 -0700 [thread overview]
Message-ID: <480CC319.5020500@intel.com> (raw)
In-Reply-To: <20080421131937.GA4685@ucw.cz>
Pavel Machek wrote:
> Hi!
>
>> [X86] IRQBALANCE: Mark as BROKEN and disable by default
>>
>> The IRQBALANCE option causes interrupts to bounce all around on SMP systems
>> quickly burying the CPU in migration cost and cache misses. Mainly affected are
>> network interrupts and this results in one CPU pegged in softirqd completely.
>>
>> Disable this option and provide documentation to a better solution (userspace
>> irqbalance daemon does overall the best job to begin with and only manual setting
>> of smp_affinity will beat it).
>>
>> Signed-off-by: Auke Kok <auke-jan.h.kok@intel.com>
>>
>> ---
>>
>> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
>> index 6c70fed..956aa22 100644
>> --- a/arch/x86/Kconfig
>> +++ b/arch/x86/Kconfig
>> @@ -1026,13 +1026,17 @@ config EFI
>> platforms.
>>
>> config IRQBALANCE
>> - def_bool y
>> + def_bool n
>
> ACK.
>> prompt "Enable kernel irq balancing"
>> - depends on X86_32 && SMP && X86_IO_APIC
>> + depends on X86_32 && SMP && X86_IO_APIC && BROKEN
>
> This is wrong. irqbalance works, there's nothing wrong with it; but it
> has nasty sideffects.
ok, I'm fine with taking that part out of the patch.
Ingo, want me to send an updated patch?
>
>> help
>> The default yes will allow the kernel to do irq load balancing.
>> Saying no will keep the kernel from doing irq load balancing.
>>
>> + This option is known to cause performance issues on SMP
>> + systems. The preferred method is to use the userspace
>> + 'irqbalance' daemon instead. See http://irqbalance.org/.
>> +
>
> ACK.
>
next prev parent reply other threads:[~2008-04-21 16:40 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1208282804.23631.27.camel@localhost>
2008-04-15 20:15 ` Bad network performance over 2Gbps H. Willstrand
2008-04-15 20:34 ` Kok, Auke
2008-04-15 20:59 ` Chris Snook
2008-04-15 21:05 ` Kok, Auke
2008-04-17 10:02 ` Anton Titov
2008-04-17 17:37 ` [PATCH] " Kok, Auke
2008-04-20 12:08 ` Denys Fedoryshchenko
2008-04-21 13:19 ` Pavel Machek
2008-04-21 16:38 ` Kok, Auke [this message]
2008-04-21 15:28 ` Ingo Molnar
2008-04-21 16:58 ` Kok, Auke
2008-04-21 18:35 ` Andi Kleen
2008-04-22 5:07 ` Bill Fink
[not found] <aiXVe-Yn-7@gated-at.bofh.it>
[not found] ` <ajGfA-7rt-9@gated-at.bofh.it>
[not found] ` <ajGfA-7rt-11@gated-at.bofh.it>
[not found] ` <ajGfA-7rt-13@gated-at.bofh.it>
[not found] ` <ajGfA-7rt-15@gated-at.bofh.it>
[not found] ` <ajGfA-7rt-7@gated-at.bofh.it>
2008-04-19 15:05 ` Bodo Eggert
[not found] ` <E1JnEcl-0000xc-D9@be1.7eggert.dyndns.org>
2008-04-19 19:23 ` Stephen Hemminger
2008-04-21 16:42 ` Rick Jones
2008-04-21 19:52 ` Bodo Eggert
2008-04-21 20:02 ` Rick Jones
2008-04-21 21:08 ` Bodo Eggert
2008-04-21 21:30 ` Chris Snook
2008-04-22 7:36 ` Bodo Eggert
2008-04-22 17:46 ` Kok, Auke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=480CC319.5020500@intel.com \
--to=auke-jan.h.kok@intel.com \
--cc=a.titov@host.bg \
--cc=akpm@linux-foundation.org \
--cc=csnook@redhat.com \
--cc=h.willstrand@gmail.com \
--cc=hpa@zytor.com \
--cc=jesse.brandeburg@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=netdev@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).