From: Patrick McHardy <kaber@trash.net>
To: David Miller <davem@davemloft.net>
Cc: tomasz@grobelny.oswiecenia.net, acme@redhat.com,
gerrit@erg.abdn.ac.uk, dccp@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [DCCP] [RFC] [Patchv2 1/1]: Queuing policies -- reworked version of Tomasz's patch set
Date: Wed, 23 Apr 2008 02:03:43 +0200 [thread overview]
Message-ID: <480E7CDF.2060301@trash.net> (raw)
In-Reply-To: <20080422.150648.158484938.davem@davemloft.net>
David Miller wrote:
> From: Tomasz Grobelny <tomasz@grobelny.oswiecenia.net>
> Date: Tue, 22 Apr 2008 22:45:53 +0200
>
>> Maybe I wasn't clear enough with my question. I understand that
>> these two memsets would have to be readded. But my question is: did
>> you identify any bugs that were caused by junk in skb->cb before
>> applying your patch? If so, do you have any test cases? It could
>> help to check code for correctness if one day more space in skb->cb
>> will be needed (which of course doesn't have to be in the nearest
>> future).
>
> I think Patrick noticed it because it broke netfilter.
>
Exactly, at least one path to the IP stack didn't clear
the CB (I don't recall the exact function, sorry). The
same is true for IPv6.
The testcase was transfering data over NATed DCCP connections,
some packets had garbage in IPCB(skb)->flags, which caused
IP to skip the POST_ROUTING hook, breaking NAT and conntrack.
next prev parent reply other threads:[~2008-04-23 0:03 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-11 10:24 [PATCH 0/5] [DCCP]: Queuing policies Tomasz Grobelny
2008-04-14 6:50 ` Gerrit Renker
2008-04-14 7:39 ` [DCCP] [RFC] [Patchv2 1/1]: Queuing policies -- reworked version of Tomasz's patch set Gerrit Renker
2008-04-14 23:45 ` Tomasz Grobelny
2008-04-15 15:14 ` Gerrit Renker
2008-04-15 15:21 ` Gerrit Renker
2008-04-15 18:01 ` Tomasz Grobelny
2008-04-16 6:20 ` Gerrit Renker
2008-04-16 8:36 ` [DCCP] [RFC] [Patchv3 " Gerrit Renker
2008-04-17 20:03 ` [DCCP] [RFC] [Patchv2 " Tomasz Grobelny
2008-04-18 10:13 ` Gerrit Renker
2008-04-19 20:42 ` Tomasz Grobelny
2008-04-20 16:57 ` Arnaldo Carvalho de Melo
2008-04-20 20:12 ` Tomasz Grobelny
2008-04-21 11:45 ` Patrick McHardy
2008-04-21 13:12 ` Arnaldo Carvalho de Melo
2008-04-21 16:17 ` Tomasz Grobelny
2008-04-22 4:56 ` Patrick McHardy
2008-04-22 20:45 ` Tomasz Grobelny
2008-04-22 22:06 ` David Miller
2008-04-23 0:03 ` Patrick McHardy [this message]
2008-04-22 17:41 ` Gerrit Renker
2008-04-22 22:42 ` David Miller
2008-04-25 19:33 ` Tomasz Grobelny
2008-04-25 20:40 ` Arnaldo Carvalho de Melo
2008-04-25 20:58 ` David Miller
2008-04-28 7:21 ` Gerrit Renker
2008-04-28 7:39 ` David Miller
2008-04-22 17:30 ` Gerrit Renker
2008-04-22 20:30 ` Tomasz Grobelny
[not found] ` <20080424220704.0483DBC12@poczta.oswiecenia.net>
2008-04-24 22:16 ` [PATCH 1/1] [DCCP][QPOLICY]: External interface changes Tomasz Grobelny
2008-04-28 15:08 ` Gerrit Renker
2008-04-28 21:29 ` Tomasz Grobelny
2008-04-28 13:10 ` [DCCP] [RFC] [Patchv2 1/1]: Queuing policies -- reworked version of Tomasz's patch set Gerrit Renker
2008-04-28 15:19 ` [DCCP] [RFC] [Patchv3 " Gerrit Renker
2008-04-28 20:12 ` Tomasz Grobelny
2008-04-28 21:03 ` [DCCP] [RFC] [Patchv2 " Tomasz Grobelny
2008-04-30 7:53 ` Gerrit Renker
2008-05-02 20:39 ` Tomasz Grobelny
2008-05-02 20:56 ` Gerrit Renker
2008-04-15 19:38 ` Tomasz Grobelny
2008-04-15 20:04 ` Arnaldo Carvalho de Melo
2008-04-17 20:20 ` Tomasz Grobelny
2008-04-15 20:14 ` inconsistent lock state with kernel 2.6.24.4 Bernard Pidoux
2008-04-16 7:43 ` [DCCP] [RFC] [Patchv2 1/1]: Queuing policies -- reworked version of Tomasz's patch set Gerrit Renker
2008-04-17 18:03 ` Tomasz Grobelny
2008-04-17 18:29 ` Gerrit Renker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=480E7CDF.2060301@trash.net \
--to=kaber@trash.net \
--cc=acme@redhat.com \
--cc=davem@davemloft.net \
--cc=dccp@vger.kernel.org \
--cc=gerrit@erg.abdn.ac.uk \
--cc=netdev@vger.kernel.org \
--cc=tomasz@grobelny.oswiecenia.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).