From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B01CA805 for ; Wed, 31 May 2023 19:31:24 +0000 (UTC) Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [IPv6:2a00:1450:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 518D8126 for ; Wed, 31 May 2023 12:31:22 -0700 (PDT) Received: by mail-ej1-x629.google.com with SMTP id a640c23a62f3a-96f7bf3cf9eso1135027166b.0 for ; Wed, 31 May 2023 12:31:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1685561481; x=1688153481; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=XzmS9Q7rcF4wK+3M4xWTzjFrvHkAxzNx2k0i9sXDaBI=; b=kmUd0XwMBxGai5Os+SkdP4FhHNwp6VP4CdwZVb4ASXJHhhW5RA30JTo0fHGGLGewCL SagSqWzSx5FUD63hlEcd4px2errlCXd1ERTf4jwER+cI9yXSLKTlc3/CRf4/tzKkX3kM 5eihEYPiPDX87UVMK8kYU9atiYTEUwDjlsOpXBMnoougeaHRkpzl8Vb7ca/kMIGfZ2fM HbcvRvqlRlXjNcptJYtsquDN+XvHmb8LBlMPKs6WzlvUZtcoNUkg9DRQgs5vtrvagyCZ KitkbHZMXXlqU6cgc5KyjUOTQHUU7jfTFXP0yER16lse8X4DOY1QpX7ZsCHf+Llc7WJL YQIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685561481; x=1688153481; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XzmS9Q7rcF4wK+3M4xWTzjFrvHkAxzNx2k0i9sXDaBI=; b=QTJdplnNTKkwo+xVOu+cWo+LTn+cNMdM/USHYQKP64oPmccVFfJRMI59FrIWliDUGN Rm3sMHfx0OSKIr7qbQT2vSkL7KOdN6w6uVt0zHlT37qpcCxX5vdF7bdA+R0jKJRKMd1d 7Ch6cqYr+1K9IBZgsTmAPCfcunfHxzLwy0zbKs4QN9aHw4uokjgxTXVmfcsjF0XBo4nE UwIF6/mipujBQXwm9VwutKxPHd8ZQDHtNvgr2gTqMy3Att2FgptuAWy8fytBQCce+M6F wFyVx+b2eZesTca+oVOy2WGlMyzXAxhu2AQ9SWJqoBNNtrgD34lA+nog3mqtBzATiBaX HN6A== X-Gm-Message-State: AC+VfDyQMfhYzHHVH+e9763Gu341/GIhaKF1egjCmXYAEYH7sQUrcFcF oesH2jPTdkhISI6mv5u5zoMD5g== X-Google-Smtp-Source: ACHHUZ7YpDIJJ0TXK1hKPptboCJTxQbTSLxMFbGHVI4pYNLLWMwUqhrBPicY9RoBCBrZKOfJ3iNNWQ== X-Received: by 2002:a17:907:25cd:b0:973:8823:f53f with SMTP id ae13-20020a17090725cd00b009738823f53fmr6334041ejc.52.1685561480773; Wed, 31 May 2023 12:31:20 -0700 (PDT) Received: from [192.168.1.20] ([178.197.199.204]) by smtp.gmail.com with ESMTPSA id ss7-20020a170907038700b0096a2eaa508asm9414104ejb.168.2023.05.31.12.31.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 31 May 2023 12:31:20 -0700 (PDT) Message-ID: <4810fb0f-2b0f-0118-435a-d7373553163a@linaro.org> Date: Wed, 31 May 2023 21:31:16 +0200 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH net-next v5 2/6] dt-bindings: net: Brcm ASP 2.0 Ethernet controller Content-Language: en-US To: Florian Fainelli , Justin Chen , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, bcm-kernel-feedback-list@broadcom.com Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, opendmb@gmail.com, andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk, richardcochran@gmail.com, sumit.semwal@linaro.org, christian.koenig@amd.com, simon.horman@corigine.com References: <1684969313-35503-1-git-send-email-justin.chen@broadcom.com> <1684969313-35503-3-git-send-email-justin.chen@broadcom.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On 31/05/2023 21:29, Florian Fainelli wrote: >>> + required: >>> + - reg >>> + - brcm,channel >>> + >>> + additionalProperties: false >>> + >>> +patternProperties: >>> + "^mdio@[0-9a-f]+$": >> >> Isn't mdio a property of each ethernet port? Existing users >> (e.g.bcmgenet, owl-emac, switches) do it that way... > > They are sub-nodes of the larger Ethernet controller block, hence the > property here. This is the Ethernet controller. They are subnodes here, so what do you mean by that? They are part of some other block? > >> >> Otherwise how do you define relation-ship? Can one mdio fit multiple ports? > > The relationship is established between Ethernet ports and children > nodes of the MDIO controller, such as switches or Ethernet PHYs using > 'phy-handle' for instance. And yes, a single/common MDIO controller > could be serving multiple Ethernet ports. We do not talk about generic case, but your device. Best regards, Krzysztof