From: Jeff Garzik <jgarzik@pobox.com>
To: Andy Fleming <afleming@freescale.com>
Cc: bunk@kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH v2.6.26] ucc_geth: Fix sneaky merge conflict regarding bus_id
Date: Fri, 25 Apr 2008 01:47:34 -0400 [thread overview]
Message-ID: <48117076.2030002@pobox.com> (raw)
In-Reply-To: <1208987777-17502-1-git-send-email-afleming@freescale.com>
Andy Fleming wrote:
> The patch that changed mdio_bus to a string didn't conflict strongly enough
> with the patch that added fixed PHY support to UCC. Gather it back into
> the fold.
>
> Fixes this error:
> ...
> CC drivers/net/ucc_geth.o
> 'ucc_geth_probe':
> /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/net/ucc_geth.c:3935: error:
> incompatible types in assignment
> make[3]: *** [drivers/net/ucc_geth.o] Error 1
>
> Signed-off-by: Andy Fleming <afleming@freescale.com>
> ---
> drivers/net/ucc_geth.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/ucc_geth.c b/drivers/net/ucc_geth.c
> index 2f11254..281ce3d 100644
> --- a/drivers/net/ucc_geth.c
> +++ b/drivers/net/ucc_geth.c
> @@ -3932,7 +3932,7 @@ static int ucc_geth_probe(struct of_device* ofdev, const struct of_device_id *ma
> ug_info->uf_info.irq = irq_of_parse_and_map(np, 0);
> fixed_link = of_get_property(np, "fixed-link", NULL);
> if (fixed_link) {
> - ug_info->mdio_bus = 0;
> + snprintf(ug_info->mdio_bus, MII_BUS_ID_SIZE, "0");
> ug_info->phy_address = fixed_link[0];
applied
prev parent reply other threads:[~2008-04-25 5:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-23 21:56 [PATCH v2.6.26] ucc_geth: Fix sneaky merge conflict regarding bus_id Andy Fleming
2008-04-25 5:47 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48117076.2030002@pobox.com \
--to=jgarzik@pobox.com \
--cc=afleming@freescale.com \
--cc=bunk@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).