From: Jeff Garzik <jeff@garzik.org>
To: Sreenivasa Honnur <Sreenivasa.Honnur@neterion.com>
Cc: netdev@vger.kernel.org, support@neterion.com
Subject: Re: [PATCH 2.6.25 1/2]S2io: Fix memory leak during free_tx_buffers
Date: Fri, 25 Apr 2008 01:48:08 -0400 [thread overview]
Message-ID: <48117098.3090500@garzik.org> (raw)
In-Reply-To: <Pine.GSO.4.10.10804231326590.10279-100000@guinness>
Sreenivasa Honnur wrote:
> - Fix the memory leak during free_tx_buffers.
>
> Signed-off-by: Santosh Rastapur <santosh.rastapur@neterion.com>
> Signed-off-by: Ramkrishna Vepa <ram.vepa@neterion.com>
> ---
> diff -Nurp 2.0.26.20/drivers/net/s2io.c 2.0.26.22-1/drivers/net/s2io.c
> --- 2.0.26.20/drivers/net/s2io.c 2008-04-22 15:02:38.000000000 -0700
> +++ 2.0.26.22-1/drivers/net/s2io.c 2008-04-22 15:12:25.000000000 -0700
> @@ -2339,7 +2339,7 @@ static void free_tx_buffers(struct s2io_
> for (i = 0; i < config->tx_fifo_num; i++) {
> unsigned long flags;
> spin_lock_irqsave(&mac_control->fifos[i].tx_lock, flags);
> - for (j = 0; j < config->tx_cfg[i].fifo_len - 1; j++) {
> + for (j = 0; j < config->tx_cfg[i].fifo_len; j++) {
> txdp = (struct TxD *) \
> mac_control->fifos[i].list_info[j].list_virt_addr;
applied 1-2 to upstream
since 2.6.25 was released, we need to put in a separate request to
stable@kernel.org
prev parent reply other threads:[~2008-04-25 5:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-23 17:28 [PATCH 2.6.25 1/2]S2io: Fix memory leak during free_tx_buffers Sreenivasa Honnur
2008-04-25 5:48 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48117098.3090500@garzik.org \
--to=jeff@garzik.org \
--cc=Sreenivasa.Honnur@neterion.com \
--cc=netdev@vger.kernel.org \
--cc=support@neterion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).