* [PATCH 2.6.25 1/2]S2io: Fix memory leak during free_tx_buffers
@ 2008-04-23 17:28 Sreenivasa Honnur
2008-04-25 5:48 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Sreenivasa Honnur @ 2008-04-23 17:28 UTC (permalink / raw)
To: netdev, jeff; +Cc: support
- Fix the memory leak during free_tx_buffers.
Signed-off-by: Santosh Rastapur <santosh.rastapur@neterion.com>
Signed-off-by: Ramkrishna Vepa <ram.vepa@neterion.com>
---
diff -Nurp 2.0.26.20/drivers/net/s2io.c 2.0.26.22-1/drivers/net/s2io.c
--- 2.0.26.20/drivers/net/s2io.c 2008-04-22 15:02:38.000000000 -0700
+++ 2.0.26.22-1/drivers/net/s2io.c 2008-04-22 15:12:25.000000000 -0700
@@ -2339,7 +2339,7 @@ static void free_tx_buffers(struct s2io_
for (i = 0; i < config->tx_fifo_num; i++) {
unsigned long flags;
spin_lock_irqsave(&mac_control->fifos[i].tx_lock, flags);
- for (j = 0; j < config->tx_cfg[i].fifo_len - 1; j++) {
+ for (j = 0; j < config->tx_cfg[i].fifo_len; j++) {
txdp = (struct TxD *) \
mac_control->fifos[i].list_info[j].list_virt_addr;
skb = s2io_txdl_getskb(&mac_control->fifos[i], txdp, j);
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 2.6.25 1/2]S2io: Fix memory leak during free_tx_buffers
2008-04-23 17:28 [PATCH 2.6.25 1/2]S2io: Fix memory leak during free_tx_buffers Sreenivasa Honnur
@ 2008-04-25 5:48 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2008-04-25 5:48 UTC (permalink / raw)
To: Sreenivasa Honnur; +Cc: netdev, support
Sreenivasa Honnur wrote:
> - Fix the memory leak during free_tx_buffers.
>
> Signed-off-by: Santosh Rastapur <santosh.rastapur@neterion.com>
> Signed-off-by: Ramkrishna Vepa <ram.vepa@neterion.com>
> ---
> diff -Nurp 2.0.26.20/drivers/net/s2io.c 2.0.26.22-1/drivers/net/s2io.c
> --- 2.0.26.20/drivers/net/s2io.c 2008-04-22 15:02:38.000000000 -0700
> +++ 2.0.26.22-1/drivers/net/s2io.c 2008-04-22 15:12:25.000000000 -0700
> @@ -2339,7 +2339,7 @@ static void free_tx_buffers(struct s2io_
> for (i = 0; i < config->tx_fifo_num; i++) {
> unsigned long flags;
> spin_lock_irqsave(&mac_control->fifos[i].tx_lock, flags);
> - for (j = 0; j < config->tx_cfg[i].fifo_len - 1; j++) {
> + for (j = 0; j < config->tx_cfg[i].fifo_len; j++) {
> txdp = (struct TxD *) \
> mac_control->fifos[i].list_info[j].list_virt_addr;
applied 1-2 to upstream
since 2.6.25 was released, we need to put in a separate request to
stable@kernel.org
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-04-25 5:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-04-23 17:28 [PATCH 2.6.25 1/2]S2io: Fix memory leak during free_tx_buffers Sreenivasa Honnur
2008-04-25 5:48 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).