From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [PATCH 1/8] e1000e: cleanup several stats issues Date: Fri, 25 Apr 2008 02:01:29 -0400 Message-ID: <481173B9.3010006@garzik.org> References: <20080423180900.24972.84015.stgit@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: e1000-devel@lists.sourceforge.net, netdev@vger.kernel.org To: Auke Kok Return-path: In-Reply-To: <20080423180900.24972.84015.stgit@localhost.localdomain> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: e1000-devel-bounces@lists.sourceforge.net Errors-To: e1000-devel-bounces@lists.sourceforge.net List-Id: netdev.vger.kernel.org Auke Kok wrote: > From: Bruce Allan > > Several stats registers are completely unused and we just waste pci > bus time reading them. We also omit using the high 32 bits of the GORC/ > GOTC counters. We can just read clear them and only read the low registers. > > Mii-tool can also break es2lan if it executes a MII PHY register > ioctl while the device is in autonegotiation. Unfortunately it seems > that several applications and installations still perform this ioctl > call periodically and especially in this crucial startup time. We > can fool the ioctl by providing fail safe information that mimics > the "down" link state and only perform the dangerous PHY reads once > after link comes up to fill in the real values. As long as link > stays up the information will not change. > > Signed-off-by: Bruce Allan > Signed-off-by: Jeff Kirsher > Signed-off-by: Jesse Brandeburg > Signed-off-by: Auke Kok applied 1-8 I was mainly waiting for the discussion of the abuse of the ethtool interface, which I chose to allow. Now, send me a patch to the ethtool man page for this new behavior :) ------------------------------------------------------------------------- This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code J8TL2D2. http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone