[PATCH] 2.6.25 typhoon_resume - remove call to start_queue

[PATCH] 2.6.25 typhoon_resume - remove call to start_queue

[Grant Grundler]

Jeff,

While trying to fix http://bugzilla.kernel.org/show_bug.cgi?id=8952
I looked at a few other drivers to figure out what drivers _should_
be doing for suspend/resume. I noticed typhoon driver is likely doing
more than it needs to.  Patch below is untested since I don't have the HW.

Suspend/resume code across NIC drivers is fairly inconsistent.
And I couldn't find any documentation on what the canonical sequence
NICs need to do for suspend or resume.  Is there any?

Barring contrary advice, I'm going model the tulip suspend/resume
fixes after tg3.c since a number of "modern" (< 5 years old) laptops
have that and I'm silly enough to assume it works.

thanks,
grant

---
Comments/code in netif_device_attach() suggest it is restarting the queue.
Thus, typhoon_resume() doesn't need to call start_queue().

Signed-off-by: Grant Grundler <grundler@parisc-linux.org>

diff --git a/drivers/net/typhoon.c b/drivers/net/typhoon.c
index 333961b..c0dd25b 100644
--- a/drivers/net/typhoon.c
+++ b/drivers/net/typhoon.c
@@ -2183,7 +2183,6 @@ typhoon_resume(struct pci_dev *pdev)
 	}
 
 	netif_device_attach(dev);
-	netif_start_queue(dev);
 	return 0;
 
 reset:

Re: [PATCH] 2.6.25 typhoon_resume - remove call to start_queue

[David Miller]

From: Grant Grundler <grundler@parisc-linux.org>
Date: Sun, 20 Apr 2008 22:44:15 -0600

> Comments/code in netif_device_attach() suggest it is restarting the queue.
> Thus, typhoon_resume() doesn't need to call start_queue().
> 
> Signed-off-by: Grant Grundler <grundler@parisc-linux.org>

Acked-by: David S. Miller <davem@davemloft.net>

Re: [PATCH] 2.6.25 typhoon_resume - remove call to start_queue

[David Dillow]

On Sun, 2008-04-20 at 22:44 -0600, Grant Grundler wrote:
> While trying to fix http://bugzilla.kernel.org/show_bug.cgi?id=8952
> I looked at a few other drivers to figure out what drivers _should_
> be doing for suspend/resume. I noticed typhoon driver is likely doing
> more than it needs to.  Patch below is untested since I don't have the HW.

I'm sure I copied this from another driver, but its been so long...
I won't be in a position to test it for a few days, but I agree it
shouldn't add break anything, so

Acked-by: Dave Dillow <dave@thedillows.org>

Re: [PATCH] 2.6.25 typhoon_resume - remove call to start_queue

[Jeff Garzik]

Grant Grundler wrote:
> Jeff,
> 
> While trying to fix http://bugzilla.kernel.org/show_bug.cgi?id=8952
> I looked at a few other drivers to figure out what drivers _should_
> be doing for suspend/resume. I noticed typhoon driver is likely doing
> more than it needs to.  Patch below is untested since I don't have the HW.
> 
> Suspend/resume code across NIC drivers is fairly inconsistent.
> And I couldn't find any documentation on what the canonical sequence
> NICs need to do for suspend or resume.  Is there any?
> 
> Barring contrary advice, I'm going model the tulip suspend/resume
> fixes after tg3.c since a number of "modern" (< 5 years old) laptops
> have that and I'm silly enough to assume it works.
> 
> thanks,
> grant
> 
> ---
> Comments/code in netif_device_attach() suggest it is restarting the queue.
> Thus, typhoon_resume() doesn't need to call start_queue().
> 
> Signed-off-by: Grant Grundler <grundler@parisc-linux.org>
> 
> diff --git a/drivers/net/typhoon.c b/drivers/net/typhoon.c
> index 333961b..c0dd25b 100644
> --- a/drivers/net/typhoon.c
> +++ b/drivers/net/typhoon.c
> @@ -2183,7 +2183,6 @@ typhoon_resume(struct pci_dev *pdev)
>  	}
>  
>  	netif_device_attach(dev);
> -	netif_start_queue(dev);
>  	return 0;
>  
>  reset:
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org

applied