From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [PATCH] 2.6.25 typhoon_resume - remove call to start_queue Date: Fri, 25 Apr 2008 02:01:45 -0400 Message-ID: <481173C9.2080509@pobox.com> References: <20080421044415.GB15080@colo.lackof.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: David Dillow , netdev@vger.kernel.org To: Grant Grundler Return-path: Received: from srv5.dvmed.net ([207.36.208.214]:58447 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754934AbYDYGBv (ORCPT ); Fri, 25 Apr 2008 02:01:51 -0400 In-Reply-To: <20080421044415.GB15080@colo.lackof.org> Sender: netdev-owner@vger.kernel.org List-ID: Grant Grundler wrote: > Jeff, > > While trying to fix http://bugzilla.kernel.org/show_bug.cgi?id=8952 > I looked at a few other drivers to figure out what drivers _should_ > be doing for suspend/resume. I noticed typhoon driver is likely doing > more than it needs to. Patch below is untested since I don't have the HW. > > Suspend/resume code across NIC drivers is fairly inconsistent. > And I couldn't find any documentation on what the canonical sequence > NICs need to do for suspend or resume. Is there any? > > Barring contrary advice, I'm going model the tulip suspend/resume > fixes after tg3.c since a number of "modern" (< 5 years old) laptops > have that and I'm silly enough to assume it works. > > thanks, > grant > > --- > Comments/code in netif_device_attach() suggest it is restarting the queue. > Thus, typhoon_resume() doesn't need to call start_queue(). > > Signed-off-by: Grant Grundler > > diff --git a/drivers/net/typhoon.c b/drivers/net/typhoon.c > index 333961b..c0dd25b 100644 > --- a/drivers/net/typhoon.c > +++ b/drivers/net/typhoon.c > @@ -2183,7 +2183,6 @@ typhoon_resume(struct pci_dev *pdev) > } > > netif_device_attach(dev); > - netif_start_queue(dev); > return 0; > > reset: > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@vger.kernel.org applied