* [PATCH] Removing dead code in /drivers/net/wan/hdlc_fr.c
@ 2008-04-20 17:15 Krzysztof Halasa
2008-04-25 6:01 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Krzysztof Halasa @ 2008-04-20 17:15 UTC (permalink / raw)
To: Jeff Garzik; +Cc: linux-kernel, netdev
From: Cédric Augonnet <Cedric.Augonnet@ens-lyon.fr>
Removing dead code in /drivers/net/wan/hdlc_fr.c
The local variable "prefix" is never used anymore, and the content of
this string appears a bit later, directly in a call to "alloc_netdev"
after doing exactly the same if/else test. So there seems to be no
point keeping those 4 lines anymore.
Signed-off-by: Cédric Augonnet <cedric.augonnet@ens-lyon.org>
Signed-off-by: Krzysztof Hałasa <khc@pm.waw.pl>
diff --git a/drivers/net/wan/hdlc_fr.c b/drivers/net/wan/hdlc_fr.c
index c4ab032..520bb0b 100644
--- a/drivers/net/wan/hdlc_fr.c
+++ b/drivers/net/wan/hdlc_fr.c
@@ -1090,10 +1090,6 @@ static int fr_add_pvc(struct net_device *frad, unsigned int dlci, int type)
pvc_device *pvc = NULL;
struct net_device *dev;
int result, used;
- char * prefix = "pvc%d";
-
- if (type == ARPHRD_ETHER)
- prefix = "pvceth%d";
if ((pvc = add_pvc(frad, dlci)) == NULL) {
printk(KERN_WARNING "%s: Memory squeeze on fr_add_pvc()\n",
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] Removing dead code in /drivers/net/wan/hdlc_fr.c
2008-04-20 17:15 [PATCH] Removing dead code in /drivers/net/wan/hdlc_fr.c Krzysztof Halasa
@ 2008-04-25 6:01 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2008-04-25 6:01 UTC (permalink / raw)
To: Krzysztof Halasa; +Cc: linux-kernel, netdev
Krzysztof Halasa wrote:
> From: Cédric Augonnet <Cedric.Augonnet@ens-lyon.fr>
>
> Removing dead code in /drivers/net/wan/hdlc_fr.c
>
> The local variable "prefix" is never used anymore, and the content of
> this string appears a bit later, directly in a call to "alloc_netdev"
> after doing exactly the same if/else test. So there seems to be no
> point keeping those 4 lines anymore.
>
> Signed-off-by: Cédric Augonnet <cedric.augonnet@ens-lyon.org>
> Signed-off-by: Krzysztof Hałasa <khc@pm.waw.pl>
>
> diff --git a/drivers/net/wan/hdlc_fr.c b/drivers/net/wan/hdlc_fr.c
> index c4ab032..520bb0b 100644
> --- a/drivers/net/wan/hdlc_fr.c
> +++ b/drivers/net/wan/hdlc_fr.c
> @@ -1090,10 +1090,6 @@ static int fr_add_pvc(struct net_device *frad, unsigned int dlci, int type)
> pvc_device *pvc = NULL;
> struct net_device *dev;
> int result, used;
> - char * prefix = "pvc%d";
> -
> - if (type == ARPHRD_ETHER)
> - prefix = "pvceth%d";
>
> if ((pvc = add_pvc(frad, dlci)) == NULL) {
applied
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-04-25 6:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-04-20 17:15 [PATCH] Removing dead code in /drivers/net/wan/hdlc_fr.c Krzysztof Halasa
2008-04-25 6:01 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).