* [PATCH] WAN: Fix confusing insmod error code for C101 too.
@ 2008-04-20 17:10 Krzysztof Halasa
2008-04-25 6:02 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Krzysztof Halasa @ 2008-04-20 17:10 UTC (permalink / raw)
To: Jeff Garzik; +Cc: linux-kernel, netdev
WAN: Fix confusing insmod error code for C101 too.
Signed-off-by: Krzysztof Hałasa <khc@pm.waw.pl>
diff --git a/drivers/net/wan/c101.c b/drivers/net/wan/c101.c
index c4c8eab..c2cc42f 100644
--- a/drivers/net/wan/c101.c
+++ b/drivers/net/wan/c101.c
@@ -402,7 +402,7 @@ static int __init c101_init(void)
#ifdef MODULE
printk(KERN_INFO "c101: no card initialized\n");
#endif
- return -ENOSYS; /* no parameters specified, abort */
+ return -EINVAL; /* no parameters specified, abort */
}
printk(KERN_INFO "%s\n", version);
@@ -420,11 +420,11 @@ static int __init c101_init(void)
c101_run(irq, ram);
if (*hw == '\x0')
- return first_card ? 0 : -ENOSYS;
+ return first_card ? 0 : -EINVAL;
}while(*hw++ == ':');
printk(KERN_ERR "c101: invalid hardware parameters\n");
- return first_card ? 0 : -ENOSYS;
+ return first_card ? 0 : -EINVAL;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] WAN: Fix confusing insmod error code for C101 too.
2008-04-20 17:10 [PATCH] WAN: Fix confusing insmod error code for C101 too Krzysztof Halasa
@ 2008-04-25 6:02 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2008-04-25 6:02 UTC (permalink / raw)
To: Krzysztof Halasa; +Cc: linux-kernel, netdev
Krzysztof Halasa wrote:
> WAN: Fix confusing insmod error code for C101 too.
>
> Signed-off-by: Krzysztof Hałasa <khc@pm.waw.pl>
>
> diff --git a/drivers/net/wan/c101.c b/drivers/net/wan/c101.c
> index c4c8eab..c2cc42f 100644
> --- a/drivers/net/wan/c101.c
> +++ b/drivers/net/wan/c101.c
> @@ -402,7 +402,7 @@ static int __init c101_init(void)
> #ifdef MODULE
> printk(KERN_INFO "c101: no card initialized\n");
> #endif
> - return -ENOSYS; /* no parameters specified, abort */
> + return -EINVAL; /* no parameters specified, abort */
> }
>
> printk(KERN_INFO "%s\n", version);
> @@ -420,11 +420,11 @@ static int __init c101_init(void)
> c101_run(irq, ram);
>
> if (*hw == '\x0')
> - return first_card ? 0 : -ENOSYS;
> + return first_card ? 0 : -EINVAL;
> }while(*hw++ == ':');
>
> printk(KERN_ERR "c101: invalid hardware parameters\n");
> - return first_card ? 0 : -ENOSYS;
> + return first_card ? 0 : -EINVAL;
> }
>
applied
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-04-25 6:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-04-20 17:10 [PATCH] WAN: Fix confusing insmod error code for C101 too Krzysztof Halasa
2008-04-25 6:02 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).