From: Jeff Garzik <jgarzik@pobox.com>
To: Andy Fleming <afleming@freescale.com>
Cc: shemminger@vyatta.com, netdev@vger.kernel.org
Subject: Re: [PATCH v2.6.26] gianfar: Fix skb allocation strategy
Date: Fri, 25 Apr 2008 02:04:20 -0400 [thread overview]
Message-ID: <48117464.4060301@pobox.com> (raw)
In-Reply-To: <1208902709-23557-1-git-send-email-afleming@freescale.com>
Andy Fleming wrote:
> gianfar was unable to handle failed skb allocation for rx buffers, so
> we were spinning until it succeeded. Actually, it was worse--we were
> spinning for a long time, and then silently failing. Instead, we take
> Stephen Hemminger's suggestion to try the allocation earlier, and drop the
> packet if it failed.
>
> We also make a couple of tweaks to how buffer descriptors are set up.
>
> Signed-off-by: Andy Fleming <afleming@freescale.com>
applied
prev parent reply other threads:[~2008-04-25 6:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-22 22:18 [PATCH v2.6.26] gianfar: Fix skb allocation strategy Andy Fleming
2008-04-25 6:04 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48117464.4060301@pobox.com \
--to=jgarzik@pobox.com \
--cc=afleming@freescale.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).