* [PATCH] tg3 : sparse cleanup
@ 2008-04-25 6:31 Eric Dumazet
2008-04-25 6:33 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Eric Dumazet @ 2008-04-25 6:31 UTC (permalink / raw)
To: Jeff Garzik; +Cc: Linux Netdev List
[-- Attachment #1: Type: text/plain, Size: 183 bytes --]
Fix the following sparse warning :
drivers/net/tg3.c:4025:3: warning: context imbalance in 'tg3_restart_hw'
- unexpected unlock
Signed-off-by: Eric Dumazet <dada1@cosmosbay.com>
[-- Attachment #2: tg3.patch --]
[-- Type: text/plain, Size: 353 bytes --]
diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c
index bc4c62b..e3f74c9 100644
--- a/drivers/net/tg3.c
+++ b/drivers/net/tg3.c
@@ -4017,6 +4017,8 @@ static int tg3_halt(struct tg3 *, int, int);
* Invoked with tp->lock held.
*/
static int tg3_restart_hw(struct tg3 *tp, int reset_phy)
+ __releases(tp->lock)
+ __acquires(tp->lock)
{
int err;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] tg3 : sparse cleanup
2008-04-25 6:31 [PATCH] tg3 : sparse cleanup Eric Dumazet
@ 2008-04-25 6:33 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2008-04-25 6:33 UTC (permalink / raw)
To: dada1; +Cc: jgarzik, netdev
From: Eric Dumazet <dada1@cosmosbay.com>
Date: Fri, 25 Apr 2008 08:31:35 +0200
> Fix the following sparse warning :
>
> drivers/net/tg3.c:4025:3: warning: context imbalance in 'tg3_restart_hw'
> - unexpected unlock
>
> Signed-off-by: Eric Dumazet <dada1@cosmosbay.com>
Applied, thanks a lot Eric.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-04-25 6:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-04-25 6:31 [PATCH] tg3 : sparse cleanup Eric Dumazet
2008-04-25 6:33 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).