From: Patrick McHardy <kaber@trash.net>
To: Jarek Poplawski <jarkao2@gmail.com>
Cc: David Miller <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: [PATCH][NET_SCHED] sch_sfq: use del_timer_sync() in sfq_destroy()
Date: Sun, 27 Apr 2008 20:24:34 +0200 [thread overview]
Message-ID: <4814C4E2.50600@trash.net> (raw)
In-Reply-To: <20080427125921.GA7480@ami.dom.local>
Jarek Poplawski wrote:
> [NET_SCHED] sch_sfq: use del_timer_sync() in sfq_destroy()
>
> Let's delete timer reliably in sfq_destroy().
This is broken, we hold dev->queue_lock in ->destroy.
next prev parent reply other threads:[~2008-04-27 18:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-27 12:59 [PATCH][NET_SCHED] sch_sfq: use del_timer_sync() in sfq_destroy() Jarek Poplawski
2008-04-27 18:24 ` Patrick McHardy [this message]
2008-04-27 19:00 ` Jarek Poplawski
2008-04-27 19:10 ` Patrick McHardy
2008-04-29 10:29 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4814C4E2.50600@trash.net \
--to=kaber@trash.net \
--cc=davem@davemloft.net \
--cc=jarkao2@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).