* [PATCH 1/2] Rename SMSC phy functions to be more generic
@ 2008-04-28 17:36 Steve Glendinning
2008-04-29 5:59 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Steve Glendinning @ 2008-04-28 17:36 UTC (permalink / raw)
To: netdev; +Cc: Jeff Garzik, Ian Saturley, Steve Glendinning
Several models of SMSC PHY have the same interrupt status and mask
registers as the LAN83C185, so these functions can service multiple
different PHY drivers.
Signed-off-by: Steve Glendinning <steve.glendinning@smsc.com>
---
drivers/net/phy/smsc.c | 14 +++++++-------
1 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/net/phy/smsc.c b/drivers/net/phy/smsc.c
index b1d8ed4..6a901f0 100644
--- a/drivers/net/phy/smsc.c
+++ b/drivers/net/phy/smsc.c
@@ -38,7 +38,7 @@
(MII_LAN83C185_ISF_INT6 | MII_LAN83C185_ISF_INT4)
-static int lan83c185_config_intr(struct phy_device *phydev)
+static int smsc_phy_config_intr(struct phy_device *phydev)
{
int rc = phy_write (phydev, MII_LAN83C185_IM,
((PHY_INTERRUPT_ENABLED == phydev->interrupts)
@@ -48,16 +48,16 @@ static int lan83c185_config_intr(struct phy_device *phydev)
return rc < 0 ? rc : 0;
}
-static int lan83c185_ack_interrupt(struct phy_device *phydev)
+static int smsc_phy_ack_interrupt(struct phy_device *phydev)
{
int rc = phy_read (phydev, MII_LAN83C185_ISF);
return rc < 0 ? rc : 0;
}
-static int lan83c185_config_init(struct phy_device *phydev)
+static int smsc_phy_config_init(struct phy_device *phydev)
{
- return lan83c185_ack_interrupt (phydev);
+ return smsc_phy_ack_interrupt (phydev);
}
@@ -73,11 +73,11 @@ static struct phy_driver lan83c185_driver = {
/* basic functions */
.config_aneg = genphy_config_aneg,
.read_status = genphy_read_status,
- .config_init = lan83c185_config_init,
+ .config_init = smsc_phy_config_init,
/* IRQ related */
- .ack_interrupt = lan83c185_ack_interrupt,
- .config_intr = lan83c185_config_intr,
+ .ack_interrupt = smsc_phy_ack_interrupt,
+ .config_intr = smsc_phy_config_intr,
.driver = { .owner = THIS_MODULE, }
};
--
1.5.4.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/2] Rename SMSC phy functions to be more generic
2008-04-28 17:36 [PATCH 1/2] Rename SMSC phy functions to be more generic Steve Glendinning
@ 2008-04-29 5:59 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2008-04-29 5:59 UTC (permalink / raw)
To: Steve Glendinning; +Cc: netdev, Ian Saturley
Steve Glendinning wrote:
> Several models of SMSC PHY have the same interrupt status and mask
> registers as the LAN83C185, so these functions can service multiple
> different PHY drivers.
>
> Signed-off-by: Steve Glendinning <steve.glendinning@smsc.com>
> ---
> drivers/net/phy/smsc.c | 14 +++++++-------
> 1 files changed, 7 insertions(+), 7 deletions(-)
applied 1-2
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-04-29 5:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-04-28 17:36 [PATCH 1/2] Rename SMSC phy functions to be more generic Steve Glendinning
2008-04-29 5:59 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).