From: Jeff Garzik <jeff@garzik.org>
To: Harvey Harrison <harvey.harrison@gmail.com>
Cc: David Miller <davem@davemloft.net>,
linux-netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH] net: eepro autoport typo
Date: Tue, 29 Apr 2008 01:59:19 -0400 [thread overview]
Message-ID: <4816B937.8020503@garzik.org> (raw)
In-Reply-To: <1209278643.14173.48.camel@brick>
Harvey Harrison wrote:
> Found by sparse dubious !x & y warning...hidden in the GetBit macro
> why !Word doesn't make any sense.
>
> Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
> ---
> drivers/net/eepro.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/eepro.c b/drivers/net/eepro.c
> index 83bda6c..56f5049 100644
> --- a/drivers/net/eepro.c
> +++ b/drivers/net/eepro.c
> @@ -633,7 +633,7 @@ static void __init printEEPROMInfo(struct net_device *dev)
> printk(KERN_DEBUG " PC: %d\n", GetBit(Word,ee_PC));
> printk(KERN_DEBUG " TPE/AUI: %d\n", GetBit(Word,ee_TPE_AUI));
> printk(KERN_DEBUG " Jabber: %d\n", GetBit(Word,ee_Jabber));
> - printk(KERN_DEBUG " AutoPort: %d\n", GetBit(!Word,ee_Jabber));
> + printk(KERN_DEBUG " AutoPort: %d\n", !GetBit(Word,ee_AutoPort));
> printk(KERN_DEBUG " Duplex: %d\n", GetBit(Word,ee_Duplex));
applied
prev parent reply other threads:[~2008-04-29 5:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-27 6:44 [PATCH] net: eepro autoport typo Harvey Harrison
2008-04-29 5:59 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4816B937.8020503@garzik.org \
--to=jeff@garzik.org \
--cc=davem@davemloft.net \
--cc=harvey.harrison@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).