* [PATCH] net: eepro autoport typo
@ 2008-04-27 6:44 Harvey Harrison
2008-04-29 5:59 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Harvey Harrison @ 2008-04-27 6:44 UTC (permalink / raw)
To: Jeff Garzik, David Miller; +Cc: linux-netdev
Found by sparse dubious !x & y warning...hidden in the GetBit macro
why !Word doesn't make any sense.
Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
---
drivers/net/eepro.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/eepro.c b/drivers/net/eepro.c
index 83bda6c..56f5049 100644
--- a/drivers/net/eepro.c
+++ b/drivers/net/eepro.c
@@ -633,7 +633,7 @@ static void __init printEEPROMInfo(struct net_device *dev)
printk(KERN_DEBUG " PC: %d\n", GetBit(Word,ee_PC));
printk(KERN_DEBUG " TPE/AUI: %d\n", GetBit(Word,ee_TPE_AUI));
printk(KERN_DEBUG " Jabber: %d\n", GetBit(Word,ee_Jabber));
- printk(KERN_DEBUG " AutoPort: %d\n", GetBit(!Word,ee_Jabber));
+ printk(KERN_DEBUG " AutoPort: %d\n", !GetBit(Word,ee_AutoPort));
printk(KERN_DEBUG " Duplex: %d\n", GetBit(Word,ee_Duplex));
}
--
1.5.5.1.270.g89765
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net: eepro autoport typo
2008-04-27 6:44 [PATCH] net: eepro autoport typo Harvey Harrison
@ 2008-04-29 5:59 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2008-04-29 5:59 UTC (permalink / raw)
To: Harvey Harrison; +Cc: David Miller, linux-netdev
Harvey Harrison wrote:
> Found by sparse dubious !x & y warning...hidden in the GetBit macro
> why !Word doesn't make any sense.
>
> Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
> ---
> drivers/net/eepro.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/eepro.c b/drivers/net/eepro.c
> index 83bda6c..56f5049 100644
> --- a/drivers/net/eepro.c
> +++ b/drivers/net/eepro.c
> @@ -633,7 +633,7 @@ static void __init printEEPROMInfo(struct net_device *dev)
> printk(KERN_DEBUG " PC: %d\n", GetBit(Word,ee_PC));
> printk(KERN_DEBUG " TPE/AUI: %d\n", GetBit(Word,ee_TPE_AUI));
> printk(KERN_DEBUG " Jabber: %d\n", GetBit(Word,ee_Jabber));
> - printk(KERN_DEBUG " AutoPort: %d\n", GetBit(!Word,ee_Jabber));
> + printk(KERN_DEBUG " AutoPort: %d\n", !GetBit(Word,ee_AutoPort));
> printk(KERN_DEBUG " Duplex: %d\n", GetBit(Word,ee_Duplex));
applied
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-04-29 5:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-04-27 6:44 [PATCH] net: eepro autoport typo Harvey Harrison
2008-04-29 5:59 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).