From: Patrick McHardy <kaber@trash.net>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: linux-crypto@vger.kernel.org, Linux Netdev List <netdev@vger.kernel.org>
Subject: Re: [RFC XFRM]: esp: fix scatterlist of out bounds access with crypto_eseqiv
Date: Tue, 29 Apr 2008 16:04:55 +0200 [thread overview]
Message-ID: <48172B07.8050401@trash.net> (raw)
In-Reply-To: <20080429135932.GA20790@gondor.apana.org.au>
Herbert Xu wrote:
> On Tue, Apr 29, 2008 at 07:09:39AM +0200, Patrick McHardy wrote:
>
>> I've attached two traces, the one from eseqiv and a similar
>> one from authenc (I've manually overriden eseqiv by chainiv
>> to test whether its responsible for the broken packets I was
>> seeing, which turned out to be the case. I'll look into that).
>>
>
> Thanks, looks like I left out the sg_is_last check in restoring
> adding scatterwalk_sg_next. Worse yet, eseqiv doesn't even
> encrypt the last block. It's a good thing the hifn driver doesn't
> work yet :)
Thanks for looking into this, the eseqiv problem is exactly the one
I'm seeing :) I'll test your patch and let you know the results.
next prev parent reply other threads:[~2008-04-29 14:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-28 18:55 [RFC XFRM]: esp: fix scatterlist of out bounds access with crypto_eseqiv Patrick McHardy
2008-04-29 1:41 ` Herbert Xu
2008-04-29 5:09 ` Patrick McHardy
2008-04-29 13:59 ` Herbert Xu
2008-04-29 14:04 ` Patrick McHardy [this message]
2008-04-29 14:11 ` Patrick McHardy
2008-04-29 14:21 ` Evgeniy Polyakov
2008-04-29 14:45 ` Herbert Xu
2008-04-29 20:57 ` Evgeniy Polyakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48172B07.8050401@trash.net \
--to=kaber@trash.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).