From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Grandegger Subject: Re: [PATCH] [POWERPC] mpc5200: Allow for fixed speed MII configurations Date: Thu, 01 May 2008 18:59:20 +0200 Message-ID: <4819F6E8.1@grandegger.com> References: <20080429230620.11248.25729.stgit@trillian.secretlab.ca> <4819F1F3.2000406@grandegger.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: linuxppc-dev@ozlabs.org, paulus@samba.org, netdev@vger.kernel.org, wd@denx.de, Domen Puncer , Sylvain Munaut To: Grant Likely Return-path: Received: from mail-out.m-online.net ([212.18.0.9]:46805 "EHLO mail-out.m-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757593AbYEAQ7X (ORCPT ); Thu, 1 May 2008 12:59:23 -0400 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: Grant Likely wrote: > On Thu, May 1, 2008 at 10:38 AM, Wolfgang Grandegger wrote: >> Hi Grant, >> >> >> Grant Likely wrote: >> > On Tue, Apr 29, 2008 at 5:06 PM, Grant Likely wrote: >> >> From: Grant Likely >> >> >> >> Various improvements for configuring the MPC5200 MII link from the >> >> device tree: >> >> * Look for 'current-speed' property for fixed speed MII links >> >> * Look for 'fsl,7-wire-mode' property for boards using the 7 wire mode >> >> * move definition of private data structure out of the header file >> >> >> >> Signed-off-by: Grant Likely >> > >> > Any more comments on this patch? I want to push it to Paulus, but I'd >> > like to have someone ack it first. >> > >> > Wolfgang, you used the previous version of this patch. Does this one >> > work for you? >> >> Sorry for the late answer. The patch works fine (under Linux 2.6.24) on >> my board with a 3-port Micrel ethernet switch. There is still a minor >> issue, though: >> >> >> - of_node_put(phy_dn); >> >> + /* Start with safe defaults for link connection */ >> >> + priv->phy_addr = FEC5200_PHYADDR_NONE; >> >> + priv->speed = 100; >> >> + priv->duplex = 0; >> >> priv->duplex is re-defined here. And instead of "0" we should use >> DUPLEX_HALF. > > Oops, > > Fixed. > > If you reply with your 'acked-by' line, then I'll push this one to > Paul so it can get into .26 Yes, of course. Add Acked-by: Wolfgang Grandegger please. Wolfgang.