netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Kok, Auke" <sofar@foo-projects.org>
To: Becky Bruce <bgill@freescale.com>, jgarzik@pobox.com
Cc: auke-jan.h.kok@intel.com, netdev@vger.kernel.org,
	e1000-devel@lists.sourceforge.net
Subject: Re: [PATCH] e1000e: use resource_size_t, not unsigned long, for phys addrs
Date: Thu, 01 May 2008 16:53:49 -0700	[thread overview]
Message-ID: <481A580D.1090200@foo-projects.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0805011757090.8700@monty.am.freescale.net>

Becky Bruce wrote:
> The use of unsigned long causes the driver to fail on 32-bit systems
> which support 64-bit resources.
> 
> Signed-off-by: Becky Bruce <becky.bruce@freescale.com>

Acked-by: Auke Kok <auke-jan.h.kok@intel.com>

thanks Becky,

Auke

> ---
> 
> Resend, with proper CC.
> 
>  drivers/net/e1000e/netdev.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/e1000e/netdev.c b/drivers/net/e1000e/netdev.c
> index 8991ab8..dae3269 100644
> --- a/drivers/net/e1000e/netdev.c
> +++ b/drivers/net/e1000e/netdev.c
> @@ -3897,8 +3897,8 @@ static int __devinit e1000_probe(struct pci_dev *pdev,
>  	struct e1000_adapter *adapter;
>  	struct e1000_hw *hw;
>  	const struct e1000_info *ei = e1000_info_tbl[ent->driver_data];
> -	unsigned long mmio_start, mmio_len;
> -	unsigned long flash_start, flash_len;
> +	resource_size_t mmio_start, mmio_len;
> +	resource_size_t flash_start, flash_len;
>  
>  	static int cards_found;
>  	int i, err, pci_using_dac;


  reply	other threads:[~2008-05-01 23:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-01 23:03 [PATCH] e1000e: use resource_size_t, not unsigned long, for phys addrs Becky Bruce
2008-05-01 23:53 ` Kok, Auke [this message]
2008-05-22 10:22 ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=481A580D.1090200@foo-projects.org \
    --to=sofar@foo-projects.org \
    --cc=auke-jan.h.kok@intel.com \
    --cc=bgill@freescale.com \
    --cc=e1000-devel@lists.sourceforge.net \
    --cc=jgarzik@pobox.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).