From: Jeff Garzik <jgarzik@pobox.com>
To: Jay Vosburgh <fubar@us.ibm.com>
Cc: netdev@vger.kernel.org, Pavel Emelyanov <xemul@openvz.org>
Subject: Re: [PATCH 1/4] bonding: Do not call free_netdev for already registered device.
Date: Tue, 06 May 2008 12:17:29 -0400 [thread overview]
Message-ID: <48208499.3000501@pobox.com> (raw)
In-Reply-To: <12097757822222-git-send-email-fubar@us.ibm.com>
Jay Vosburgh wrote:
> From: Pavel Emelyanov <xemul@openvz.org>
>
> If the call to bond_create_sysfs_entry in bond_create fails, the
> proper rollback is to call unregister_netdevice, not free_netdev.
> Otherwise - kernel BUG at net/core/dev.c:4057!
>
> Checked with artificial failures injected into bond_create_sysfs_entry.
>
> Pavel's original patch modified by Jay Vosburgh to move code around
> for clarity (remove goto-hopping within the unwind block).
>
> Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
> Signed-off-by: Jay Vosburgh <fubar@us.ibm.com>
> ---
> drivers/net/bonding/bond_main.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
applied 1-4
prev parent reply other threads:[~2008-05-06 16:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-03 0:49 [PATCH 0/4] bonding: bug fixes for 2.6.26 Jay Vosburgh
2008-05-03 0:49 ` [PATCH 1/4] bonding: Do not call free_netdev for already registered device Jay Vosburgh
2008-05-03 0:49 ` [PATCH 2/4] bonding: fix error unwind in bonding_store_bonds Jay Vosburgh
2008-05-03 0:49 ` [PATCH 3/4] bonding: Deadlock between bonding_store_bonds and bond_destroy_sysfs Jay Vosburgh
2008-05-03 0:49 ` [PATCH 4/4] bonding: fix enslavement error unwinds Jay Vosburgh
2008-05-03 0:52 ` David Miller
2008-05-03 1:06 ` [PATCH REPOST " Jay Vosburgh
2008-05-03 1:07 ` David Miller
2008-05-03 0:51 ` [PATCH 3/4] bonding: Deadlock between bonding_store_bonds and bond_destroy_sysfs David Miller
2008-05-03 0:51 ` [PATCH 2/4] bonding: fix error unwind in bonding_store_bonds David Miller
2008-05-03 0:51 ` [PATCH 1/4] bonding: Do not call free_netdev for already registered device David Miller
2008-05-06 16:17 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48208499.3000501@pobox.com \
--to=jgarzik@pobox.com \
--cc=fubar@us.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).