* [PATCH] ucc_geth: Don't use RX clock as TX clock.
@ 2008-04-29 11:03 Joakim Tjernlund
2008-04-29 11:07 ` Li Yang
2008-05-06 16:28 ` Jeff Garzik
0 siblings, 2 replies; 3+ messages in thread
From: Joakim Tjernlund @ 2008-04-29 11:03 UTC (permalink / raw)
To: Netdev, Li Yang, Timur Tabi; +Cc: Joakim Tjernlund
Commit 9fb1e350e16164d56990dde036ae9c0a2fd3f634,
ucc_geth: use rx-clock-name and tx-clock-name device tree properties
Introduced a typo that made the driver use the RX clock
as TX clock, causing massive TX errors.
Signed-off-by: Joakim Tjernlund <Joakim.Tjernlund@transmode.se>
---
Resending as the first one got rejected du to missing commas.
drivers/net/ucc_geth.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/ucc_geth.c b/drivers/net/ucc_geth.c
index 28431aa..2de153f 100644
--- a/drivers/net/ucc_geth.c
+++ b/drivers/net/ucc_geth.c
@@ -3907,7 +3907,7 @@ static int ucc_geth_probe(struct of_device* ofdev, const struct of_device_id *ma
return -EINVAL;
}
} else {
- prop = of_get_property(np, "rx-clock", NULL);
+ prop = of_get_property(np, "tx-clock", NULL);
if (!prop) {
printk(KERN_ERR
"ucc_geth: mising tx-clock-name property\n");
--
1.5.5.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH] ucc_geth: Don't use RX clock as TX clock.
2008-04-29 11:03 [PATCH] ucc_geth: Don't use RX clock as TX clock Joakim Tjernlund
@ 2008-04-29 11:07 ` Li Yang
2008-05-06 16:28 ` Jeff Garzik
1 sibling, 0 replies; 3+ messages in thread
From: Li Yang @ 2008-04-29 11:07 UTC (permalink / raw)
To: Jeff Garzik; +Cc: Joakim Tjernlund, Netdev, Tabi Timur
> -----Original Message-----
> From: Joakim Tjernlund [mailto:Joakim.Tjernlund@transmode.se]
> Sent: Tuesday, April 29, 2008 7:04 PM
> To: Netdev; Li Yang; Tabi Timur
> Cc: Joakim Tjernlund
> Subject: [PATCH] ucc_geth: Don't use RX clock as TX clock.
>
> Commit 9fb1e350e16164d56990dde036ae9c0a2fd3f634,
> ucc_geth: use rx-clock-name and tx-clock-name device tree
> properties Introduced a typo that made the driver use the RX
> clock as TX clock, causing massive TX errors.
>
> Signed-off-by: Joakim Tjernlund <Joakim.Tjernlund@transmode.se>
Acked-by: Li Yang <leoli@freescale.com>
> ---
>
> Resending as the first one got rejected du to missing commas.
>
> drivers/net/ucc_geth.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/ucc_geth.c b/drivers/net/ucc_geth.c
> index 28431aa..2de153f 100644
> --- a/drivers/net/ucc_geth.c
> +++ b/drivers/net/ucc_geth.c
> @@ -3907,7 +3907,7 @@ static int ucc_geth_probe(struct
> of_device* ofdev, const struct of_device_id *ma
> return -EINVAL;
> }
> } else {
> - prop = of_get_property(np, "rx-clock", NULL);
> + prop = of_get_property(np, "tx-clock", NULL);
> if (!prop) {
> printk(KERN_ERR
> "ucc_geth: mising tx-clock-name
> property\n");
> --
> 1.5.5.1
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ucc_geth: Don't use RX clock as TX clock.
2008-04-29 11:03 [PATCH] ucc_geth: Don't use RX clock as TX clock Joakim Tjernlund
2008-04-29 11:07 ` Li Yang
@ 2008-05-06 16:28 ` Jeff Garzik
1 sibling, 0 replies; 3+ messages in thread
From: Jeff Garzik @ 2008-05-06 16:28 UTC (permalink / raw)
To: Joakim Tjernlund; +Cc: Netdev, Li Yang, Timur Tabi
Joakim Tjernlund wrote:
> Commit 9fb1e350e16164d56990dde036ae9c0a2fd3f634,
> ucc_geth: use rx-clock-name and tx-clock-name device tree properties
> Introduced a typo that made the driver use the RX clock
> as TX clock, causing massive TX errors.
>
> Signed-off-by: Joakim Tjernlund <Joakim.Tjernlund@transmode.se>
> ---
>
> Resending as the first one got rejected du to missing commas.
>
> drivers/net/ucc_geth.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
applied
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-05-06 16:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-04-29 11:03 [PATCH] ucc_geth: Don't use RX clock as TX clock Joakim Tjernlund
2008-04-29 11:07 ` Li Yang
2008-05-06 16:28 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).