From: Paolo Abeni <pabeni@redhat.com>
To: Eric Dumazet <edumazet@google.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>
Cc: Simon Horman <horms@kernel.org>,
netdev@vger.kernel.org, eric.dumazet@gmail.com,
syzbot+d6fa74e3f19d6ee01e3a@syzkaller.appspotmail.com,
James Chapman <jchapman@katalix.com>,
Guillaume Nault <gnault@redhat.com>
Subject: Re: [PATCH v2 net] l2tp: fix tunnel and session refcount leak on seq_file release
Date: Tue, 11 Aug 2026 12:20:39 +0200 [thread overview]
Message-ID: <4821130f-2416-42f6-b3cc-c0cfc12ffaa0@redhat.com> (raw)
In-Reply-To: <20260810141125.1176545-1-edumazet@google.com>
On 8/10/26 4:11 PM, Eric Dumazet wrote:
> @@ -1608,8 +1655,8 @@ static __net_init int pppol2tp_init_net(struct net *net)
> struct proc_dir_entry *pde;
> int err = 0;
>
> - pde = proc_create_net("pppol2tp", 0444, net->proc_net,
> - &pppol2tp_seq_ops, sizeof(struct pppol2tp_seq_data));
> + pde = proc_create_data("pppol2tp", 0444, net->proc_net,
> + &pppol2tp_proc_ops, net);
It looks like the above does not build with CONFIG_PROC_FS=n:
net/l2tp/l2tp_ppp.c: In function ‘pppol2tp_init_net’:
net/l2tp/l2tp_ppp.c:1659:33: error: ‘pppol2tp_proc_ops’ undeclared (first use in this function); did you mean ‘pppol2tp_chan_ops’?
1659 | &pppol2tp_proc_ops, net);
| ^~~~~~~~~~~~~~~~~
| pppol2tp_chan_ops
/P
next prev parent reply other threads:[~2026-08-11 10:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-10 14:11 [PATCH v2 net] l2tp: fix tunnel and session refcount leak on seq_file release Eric Dumazet
2026-08-11 10:20 ` Paolo Abeni [this message]
2026-08-11 10:59 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4821130f-2416-42f6-b3cc-c0cfc12ffaa0@redhat.com \
--to=pabeni@redhat.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=gnault@redhat.com \
--cc=horms@kernel.org \
--cc=jchapman@katalix.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=syzbot+d6fa74e3f19d6ee01e3a@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).