netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Oliver Hartkopp <oliver@hartkopp.net>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: stable@kernel.org, David Miller <davem@davemloft.net>,
	urs@isnogud.escape.de, netdev@vger.kernel.org
Subject: Re: [PATCH] [2.6.26] [CAN] Fix can_send() handling on dev_queue_xmit() failures
Date: Thu, 08 May 2008 20:27:49 +0200	[thread overview]
Message-ID: <48234625.5020706@hartkopp.net> (raw)
In-Reply-To: <20080508172938.GA7461@uranus.ravnborg.org>

Sam Ravnborg wrote:
> On Thu, May 08, 2008 at 07:00:39PM +0200, Oliver Hartkopp wrote:
>   
>>
>>
>> Maybe we should also consider to push the patch from Sam regarding the 
>> wrong copy_from_user() results interpretation to the stable tree:
>>
>> can: Fix copy_from_user() results interpretation
>>
>> author 	Sam Ravnborg <sam@ravnborg.org>
>>
>> 	Sun, 27 Apr 2008 05:57:25 +0000 (22:57 -0700)
>> committer 	David S. Miller <davem@davemloft.net>
>>
>> 	Sun, 27 Apr 2008 21:26:51 +0000 (14:26 -0700)
>> commit 	3f91bd420a955803421f2db17b2e04aacfbb2bb8
>>     
>
> I recall tat I considered stable material when I did
> this patch. But as I merely just did a codingstyle update
> of the old patch I dropped it.
>
> But looks like possible -stable materail so I've added
> stable@kernel.org to the to list so they can judge.
>   

Yep. Thanks.

Indeed you updated the codingstyle from a patch suggested by Pavel - but 
his (original) patch fixes the copy_from_user() result interpretation. 
So it was not only a codingstyle patch which was commited here.

Best regards,
Oliver


  reply	other threads:[~2008-05-08 18:27 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-06 19:49 [PATCH] [2.6.26] [CAN] Fix can_send() handling on dev_queue_xmit() failures Oliver Hartkopp
2008-05-08  9:50 ` David Miller
2008-05-08 17:00   ` Oliver Hartkopp
2008-05-08 17:29     ` Sam Ravnborg
2008-05-08 18:27       ` Oliver Hartkopp [this message]
2008-05-13 17:46       ` [stable] " Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48234625.5020706@hartkopp.net \
    --to=oliver@hartkopp.net \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=sam@ravnborg.org \
    --cc=stable@kernel.org \
    --cc=urs@isnogud.escape.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).