From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vlad Yasevich Subject: Re: [PATCH] [SCTP]: Add address type check while process paramaters of ASCONF chunk Date: Tue, 13 May 2008 08:48:39 -0400 Message-ID: <48298E27.40100@hp.com> References: <1210360195-16524-1-git-send-email-vladislav.yasevich@hp.com> <1210360195-16524-2-git-send-email-vladislav.yasevich@hp.com> <48297BE9.9020204@trash.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, davem@davemloft.net, linux-sctp@vger.kernel.org, lksctp-developers@lists.sourceforge.net, Wei Yongjun To: Patrick McHardy Return-path: Received: from g4t0014.houston.hp.com ([15.201.24.17]:6667 "EHLO g4t0014.houston.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754304AbYEMMss (ORCPT ); Tue, 13 May 2008 08:48:48 -0400 In-Reply-To: <48297BE9.9020204@trash.net> Sender: netdev-owner@vger.kernel.org List-ID: Patrick McHardy wrote: > Vlad Yasevich wrote: >> @@ -2827,6 +2827,19 @@ static __be16 sctp_process_asconf_param(struct >> sctp_association *asoc, >> union sctp_addr addr; >> union sctp_addr_param *addr_param; >> >> + switch (addr_param->v4.param_hdr.type) { > > ^^^ use of addr_param > >> + case SCTP_PARAM_IPV6_ADDRESS: >> + if (!asoc->peer.ipv6_address) >> + return SCTP_ERROR_INV_PARAM; >> + break; >> + case SCTP_PARAM_IPV4_ADDRESS: >> + if (!asoc->peer.ipv4_address) >> + return SCTP_ERROR_INV_PARAM; >> + break; >> + default: >> + return SCTP_ERROR_INV_PARAM; >> + } >> + >> addr_param = (union sctp_addr_param *) >> ((void *)asconf_param + sizeof(sctp_addip_param_t)); > > ^^^ initialization of addr_param > > The patch is wrong and needs this fix on top. > Ack. David, please apply. I missed this warning in the my builds... Thanks -vlad