* [PATCH] fec_mpc52xx: MPC52xx_MESSAGES_DEFAULT: 2nd NETIF_MSG_IFDOWN => IFUP [not found] ` <482A8DFD.3080805@246tnt.com> @ 2008-05-14 8:10 ` Roel Kluin 2008-05-14 8:30 ` Sylvain Munaut 0 siblings, 1 reply; 2+ messages in thread From: Roel Kluin @ 2008-05-14 8:10 UTC (permalink / raw) To: Sylvain Munaut; +Cc: lkml, netdev Sylvain Munaut wrote: > Roel Kluin wrote: >> in drivers/net/fec_mpc52xx.c:81 it reads: >> >> #define MPC52xx_MESSAGES_DEFAULT ( NETIF_MSG_DRV | NETIF_MSG_PROBE | \ >> NETIF_MSG_LINK | NETIF_MSG_IFDOWN | NETIF_MSG_IFDOWN ) >> >> should this maybe be >> >> NETIF_MSG_IFUP | NETIF_MSG_IFDOWN ) >> >> ? >> >> > Yes but I remember seeing a patch for this already ... What kernel > version / revision do you have ? > > Sylvain Indeed I already sent the patch, see http://lkml.org/lkml/2008/1/30/252 (my emailaddress changed), but there was no response and the patch isn't included in current Linus' git. maybe if you could add your ack? --- duplicate NETIF_MSG_IFDOWN, 2nd should be NETIF_MSG_IFUP Signed-off-by: Roel Kluin <roel.kluin@gmail.com> --- diff --git a/drivers/net/fec_mpc52xx.c b/drivers/net/fec_mpc52xx.c index 5f9c42e..329edd9 100644 --- a/drivers/net/fec_mpc52xx.c +++ b/drivers/net/fec_mpc52xx.c @@ -78,7 +78,7 @@ module_param_array_named(mac, mpc52xx_fec_mac_addr, byte, NULL, 0); MODULE_PARM_DESC(mac, "six hex digits, ie. 0x1,0x2,0xc0,0x01,0xba,0xbe"); #define MPC52xx_MESSAGES_DEFAULT ( NETIF_MSG_DRV | NETIF_MSG_PROBE | \ - NETIF_MSG_LINK | NETIF_MSG_IFDOWN | NETIF_MSG_IFDOWN ) + NETIF_MSG_LINK | NETIF_MSG_IFDOWN | NETIF_MSG_IFUP) static int debug = -1; /* the above default */ module_param(debug, int, 0); MODULE_PARM_DESC(debug, "debugging messages level"); ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] fec_mpc52xx: MPC52xx_MESSAGES_DEFAULT: 2nd NETIF_MSG_IFDOWN => IFUP 2008-05-14 8:10 ` [PATCH] fec_mpc52xx: MPC52xx_MESSAGES_DEFAULT: 2nd NETIF_MSG_IFDOWN => IFUP Roel Kluin @ 2008-05-14 8:30 ` Sylvain Munaut 0 siblings, 0 replies; 2+ messages in thread From: Sylvain Munaut @ 2008-05-14 8:30 UTC (permalink / raw) To: Roel Kluin; +Cc: lkml, netdev Roel Kluin wrote: >> Yes but I remember seeing a patch for this already ... What kernel >> version / revision do you have ? >> >> Sylvain >> > > Indeed I already sent the patch, see http://lkml.org/lkml/2008/1/30/252 (my > emailaddress changed), but there was no response and the patch isn't included in > current Linus' git. maybe if you could add your ack? > Sure thing. Acked-by: Sylvain Munaut <tnt@246tNt.com> > --- > duplicate NETIF_MSG_IFDOWN, 2nd should be NETIF_MSG_IFUP > > Signed-off-by: Roel Kluin <roel.kluin@gmail.com> > --- > diff --git a/drivers/net/fec_mpc52xx.c b/drivers/net/fec_mpc52xx.c > index 5f9c42e..329edd9 100644 > --- a/drivers/net/fec_mpc52xx.c > +++ b/drivers/net/fec_mpc52xx.c > @@ -78,7 +78,7 @@ module_param_array_named(mac, mpc52xx_fec_mac_addr, byte, NULL, 0); > MODULE_PARM_DESC(mac, "six hex digits, ie. 0x1,0x2,0xc0,0x01,0xba,0xbe"); > > #define MPC52xx_MESSAGES_DEFAULT ( NETIF_MSG_DRV | NETIF_MSG_PROBE | \ > - NETIF_MSG_LINK | NETIF_MSG_IFDOWN | NETIF_MSG_IFDOWN ) > + NETIF_MSG_LINK | NETIF_MSG_IFDOWN | NETIF_MSG_IFUP) > static int debug = -1; /* the above default */ > module_param(debug, int, 0); > MODULE_PARM_DESC(debug, "debugging messages level"); > > ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-05-14 8:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <482A05E7.90204@gmail.com>
[not found] ` <482A8DFD.3080805@246tnt.com>
2008-05-14 8:10 ` [PATCH] fec_mpc52xx: MPC52xx_MESSAGES_DEFAULT: 2nd NETIF_MSG_IFDOWN => IFUP Roel Kluin
2008-05-14 8:30 ` Sylvain Munaut
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).