From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andi Kleen Subject: Re: [PATCH] Re: [PATCH] drivers/net: remove network drivers' last few uses of IRQF_SAMPLE_RANDOM Date: Fri, 16 May 2008 18:25:12 +0200 Message-ID: <482DB568.1040704@firstfloor.org> References: <20080515142154.0595e475@core> <36D9DB17C6DE9E40B059440DB8D95F52052D71BB@orsmsx418.amr.corp.intel.com> <20080515173939.1ec968be@core> <482C7DA3.1090809@garzik.org> <482C953A.4080205@garzik.org> <87abirytxj.fsf@basil.nowhere.org> <20080516105635.6cb1f505@core> <482D5FC5.2070103@firstfloor.org> <20080516121239.GA9627@gondor.apana.org.au> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Alan Cox , Jeff Garzik , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Andrew Morton , "Brandeburg, Jesse" , Chris Peterson , tpmdd-devel@lists.sourceforge.net, tpm@selhorst.net To: Herbert Xu Return-path: Received: from one.firstfloor.org ([213.235.205.2]:39170 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751378AbYEPQZP (ORCPT ); Fri, 16 May 2008 12:25:15 -0400 In-Reply-To: <20080516121239.GA9627@gondor.apana.org.au> Sender: netdev-owner@vger.kernel.org List-ID: Herbert Xu wrote: > On Fri, May 16, 2008 at 12:19:49PM +0200, Andi Kleen wrote: >> Just think a little bit: system has no randomness source except the >> hardware RNG. you do your strange randomness verification. if it fails >> what do you do? You don't feed anything into your entropy pool and all >> your random output is predictable (just boot time) If you add anything >> predictable from another source it's still predictable, no difference. > > You can continue to feed data into the pool even if it fails the > test. You just keep the entropy value same as before. You could do that, but what advantage would it have? I don't think it's worth running the FIPS test, or rather requiring the user land daemon and leaving behind most of the userbase just for this. -Andi