From: Arjan van de Ven <arjan@linux.intel.com>
To: Andrea Arcangeli <andrea@qumranet.com>
Cc: Robert Hancock <hancockr@shaw.ca>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
NetDev <netdev@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Jeff Garzik <jgarzik@pobox.com>,
Jens Axboe <jens.axboe@oracle.com>
Subject: Re: Top kernel oopses/warnings for the week of May 16th 2008
Date: Sat, 17 May 2008 07:57:26 -0700 [thread overview]
Message-ID: <482EF256.8030305@linux.intel.com> (raw)
In-Reply-To: <20080517141235.GA13130@duo>
Andrea Arcangeli wrote:
> The reason I touched that code, is that a change introduced during
> 2.6.25-rc initialized the isa dma pool even if not necessary and that
> broke the reserved-ram patch that requires no __GFP_DMA
> allocations. There was no crash in 2.6.24 based kernels, the
> regression started in 2.6.25-rc.
I'd not really call "breaks external patch" a regression ;)
What we really ought to be doing is always initialize the pool, from
the right process context. However, we need to make it such that we
can detect that there is zero __GFP_DMA memory in the system, and bail
out in that case. Doing it on-demand is just not going to fly; by that
time it's just too late (the pool may have been eaten already, the context
might be nasty to do allocations from etc etc).
the sata_nv driver has to do it on finding a cdrom; afaik it has something
like a different DMA mask for disks and cdroms, and it scales down once you
insert a CD.
next prev parent reply other threads:[~2008-05-17 14:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <fa.LFS/TATb5YijFetLw6A+gczrVAQ@ifi.uio.no>
2008-05-17 1:55 ` Top kernel oopses/warnings for the week of May 16th 2008 Robert Hancock
2008-05-17 14:12 ` Andrea Arcangeli
2008-05-17 14:57 ` Arjan van de Ven [this message]
2008-05-17 20:34 ` Andrea Arcangeli
2008-05-17 17:38 ` Robert Hancock
[not found] <fa.d+EaKQa5MirlzoI/uZKGy3xe0h0@ifi.uio.no>
[not found] ` <fa.TM0B9DZ+uvPYd9hbDhfuRgtReEk@ifi.uio.no>
[not found] ` <fa.aEHVuArwNEvL0BbdjUyZdMtgx5s@ifi.uio.no>
[not found] ` <fa.Td5KtiJWRKP94D9KrvGd+GkHdW0@ifi.uio.no>
[not found] ` <fa.wtWnOZVeQ06/16BVE5ml7FVHP+c@ifi.uio.no>
2008-05-19 2:23 ` Robert Hancock
2008-05-16 16:41 Arjan van de Ven
2008-05-16 17:14 ` Evgeniy Polyakov
2008-05-16 18:04 ` Adrian Bunk
2008-05-16 18:19 ` Arjan van de Ven
2008-05-20 3:53 ` Dave Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=482EF256.8030305@linux.intel.com \
--to=arjan@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=andrea@qumranet.com \
--cc=hancockr@shaw.ca \
--cc=jens.axboe@oracle.com \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).