Netdev List
 help / color / mirror / Atom feed
From: "Chuck Lever" <cel@kernel.org>
To: "Ren Wei" <weir@nebusec.ai>
Cc: kernel-tls-handshake@lists.linux.dev, netdev@vger.kernel.org,
	davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	pabeni@redhat.com, horms@kernel.org, vega@nebusec.ai,
	sashiko-bot@kernel.org, rakukuip@gmail.com
Subject: Re: [PATCH net 1/1] net/handshake: Protect request hash lookups
Date: Sun, 20 Sep 2026 14:41:24 -0400	[thread overview]
Message-ID: <482ef2fa-b651-46f2-8721-8a2fe45e5599@slotpi15m67> (raw)
In-Reply-To: <01a84794d26de3d9b78ccfb5f34025cd67429290.1789819174.git.rakukuip@gmail.com>

On Mon, Sep 21, 2026 at 01:04:13AM +0800, Ren Wei wrote:
> Fix these races by introducing a kref reference count and rcu_head to
> struct handshake_req. handshake_req_hash_lookup() now safely acquires a
> reference using kref_get_unless_zero() under rcu_read_lock(). Likewise,
> handshake_req_next() acquires a reference under hn_lock, and callers
> release their references using handshake_req_put(). Releasing the final
> reference in handshake_req_put() frees the request via kfree_rcu().

Reviewed-by: Chuck Lever <cel@kernel.org>


-- 
Chuck Lever (Come to NFS bake-a-thon! https://nfsv4bat.org)

  reply	other threads:[~2026-09-20 18:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-20 17:04 [PATCH net 0/1] net/handshake: Protect request hash lookups Ren Wei
2026-09-20 17:04 ` [PATCH net 1/1] " Ren Wei
2026-09-20 18:41   ` Chuck Lever [this message]
2026-09-24  1:57   ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=482ef2fa-b651-46f2-8721-8a2fe45e5599@slotpi15m67 \
    --to=cel@kernel.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=kernel-tls-handshake@lists.linux.dev \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=rakukuip@gmail.com \
    --cc=sashiko-bot@kernel.org \
    --cc=vega@nebusec.ai \
    --cc=weir@nebusec.ai \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox