From: Patrick McHardy <kaber@trash.net>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: netdev@vger.kernel.org, bugme-daemon@bugzilla.kernel.org,
devzero@web.de, Robert Olsson <robert.olsson@its.uu.se>,
"Denis V. Lunev" <den@openvz.org>,
Pavel Emelyanov <xemul@openvz.org>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Ben Greear <greearb@candelatech.com>
Subject: Re: [Bugme-new] [Bug 10737] New: pktgen procfs problem
Date: Sun, 18 May 2008 17:31:01 +0200 [thread overview]
Message-ID: <48304BB5.7090805@trash.net> (raw)
In-Reply-To: <48302E09.8080701@trash.net>
Patrick McHardy wrote:
>>>> I've been looking into the same problem, without much success so
>>>> far. The problem appears to affect any /proc/net file, but not
>>>> files outside of /proc/net, so I'm guessing its net-ns related.
>>>> A testcase found by Ben Greear is opening the file multiple times:
>>>>
>>>> # /tmp/open /proc/net/kpktgen_0
>>>>
>>>> => refcnt goes to 1
>>>>
>>>> ^C
>>>>
>>>> => refcnt goes to 0
>>>>
>>>> Without ^C and opening the file a second time:
>>>>
>>>> # /tmp/open /proc/net/kpktgen_0
>>>>
>>>> => refcnt goes to 2 (sometimes also 11)
>>>>
>>>> ^C
>>>>
>>>> => refcnt stays at previous value.
>>>>
>>>> The refcnt even leaks if the file can't be successfully opened,
>>>> for example because of lacking permissions.
>>>>
>>>
>>> urgh. Is any of this known to be post-2.6.25?
>>>
>>
>> 2.6.25 is also affected. I don't know about earlier kernels.
>
> Some more information: the problem seems to occur only if
> the file is opened by two different processes.
>
> I'm starting a bisection now.
git-bisect identified e9720acd ([NET]: Make /proc/net a symlink
on /proc/self/net (v3)) as the guilty commit. I couldn't find
the problem in that commit, so someone with a better understanding
of how this is supposed to work should look into it.
next prev parent reply other threads:[~2008-05-18 15:31 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <bug-10737-10286@http.bugzilla.kernel.org/>
2008-05-17 21:10 ` [Bugme-new] [Bug 10737] New: pktgen procfs problem Andrew Morton
2008-05-18 1:39 ` Patrick McHardy
2008-05-18 4:56 ` Andrew Morton
2008-05-18 12:06 ` Patrick McHardy
2008-05-18 13:24 ` Patrick McHardy
2008-05-18 15:31 ` Patrick McHardy [this message]
2008-05-19 7:54 ` Denis V. Lunev
2008-05-19 10:34 ` Patrick McHardy
2008-05-20 0:26 ` Ben Greear
2008-05-20 1:14 ` Eric W. Biederman
2008-05-20 8:25 ` Robert Olsson
2008-05-19 21:34 ` Eric W. Biederman
2008-05-19 22:19 ` Ben Greear
2008-05-19 15:19 Alexey Dobriyan
-- strict thread matches above, loose matches on Subject: below --
2008-05-19 16:03 Alexey Dobriyan
2008-05-19 22:21 Alexey Dobriyan
2008-05-19 22:45 ` Robert Olsson
2008-05-20 21:57 Alexey Dobriyan
2008-05-20 21:17 ` Robert Olsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48304BB5.7090805@trash.net \
--to=kaber@trash.net \
--cc=akpm@linux-foundation.org \
--cc=bugme-daemon@bugzilla.kernel.org \
--cc=den@openvz.org \
--cc=devzero@web.de \
--cc=ebiederm@xmission.com \
--cc=greearb@candelatech.com \
--cc=netdev@vger.kernel.org \
--cc=robert.olsson@its.uu.se \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).