From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick McHardy Subject: Re: [RFC, VLAN]: Propagate selected feature bits to VLAN devices Date: Tue, 20 May 2008 19:23:54 +0200 Message-ID: <4833092A.3070800@trash.net> References: <4832E223.7020206@trash.net> <20080520144822.GR28241@solarflare.com> <4832E55E.2030009@trash.net> <4832F260.5000104@candelatech.com> <20080520162011.GT28241@solarflare.com> <4832FC1F.90208@candelatech.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: Ben Greear , Ben Hutchings , Linux Netdev List To: "Waskiewicz Jr, Peter P" Return-path: Received: from stinky.trash.net ([213.144.137.162]:45461 "EHLO stinky.trash.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754159AbYETRXy (ORCPT ); Tue, 20 May 2008 13:23:54 -0400 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: Waskiewicz Jr, Peter P wrote: >> I guess it doesn't matter so much to me either way..so long >> as it is narrowed one way or another, and preferably narrowed >> enough to allow plenty of new flags down the road. > > In addition to TSO, we also want TCP checksum offload, so we'll need at > least one more flag. So whatever is done to shrink the GSO bits, we'll > need room for two new flags. You're right of course, seems I wasn't thinking :) > > The patch looks good after a visual inspection. I'll send test results > later today. Thanks.