From: Divy Le Ray <divy@chelsio.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: jeff@garzik.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, swise@opengridcomputing.com
Subject: Re: [PATCH 2/3 2.6.27] cxgb3 - Add page support to jumbo frame Rx queue
Date: Wed, 21 May 2008 18:55:30 -0700 [thread overview]
Message-ID: <4834D292.5020907@chelsio.com> (raw)
In-Reply-To: <20080521172024.a1044aea.akpm@linux-foundation.org>
Andrew Morton wrote:
> On Tue, 20 May 2008 18:57:37 -0700
> Divy Le Ray <divy@chelsio.com> wrote:
>
>
>> From: Divy Le Ray <divy@chelsio.com>
>>
>> Add page support to Jumbo frame Rx queues.
>>
>> ...
>>
>> @@ -460,7 +464,8 @@ nomem: q->alloc_failed++;
>> if (q->use_pages) {
>> if (q->pg_chunk.page) {
>> put_page(q->pg_chunk.page);
>> - __free_page(q->pg_chunk.page);
>> + __free_pages(q->pg_chunk.page,
>> + q->order);
>> q->pg_chunk.page =
>> sd->pg_chunk.page = NULL;
>> }
>>
>
> This hunk doesn't apply to 2.6.26-rc3, afacit. The code it's patching
> just isn't there. But I think I fixed it up OK.
>
My bad.
I modified the first patch just before submission - namely to avoid
freeing the Rx page if the DMA mapping failed.
I managed to submit without locally pushing the follwing patches first.
Sorry about that.
I'm resubmitting the series.
Cheers,
Divy
prev parent reply other threads:[~2008-05-22 1:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-21 1:57 [PATCH 2/3 2.6.27] cxgb3 - Add page support to jumbo frame Rx queue Divy Le Ray
2008-05-22 0:20 ` Andrew Morton
2008-05-22 1:55 ` Divy Le Ray [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4834D292.5020907@chelsio.com \
--to=divy@chelsio.com \
--cc=akpm@linux-foundation.org \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=swise@opengridcomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).