From: Pavel Emelyanov <xemul@openvz.org>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: build failure from ip6mr stats change.
Date: Thu, 22 May 2008 12:32:00 +0400 [thread overview]
Message-ID: <48352F80.6010708@openvz.org> (raw)
In-Reply-To: <20080521.144235.43063395.davem@davemloft.net>
David Miller wrote:
> How could you possibly have test compiled this?
>
> You kept the "stats->foo" dereferences but those all
> need to be "stats.foo"
Yikes! 8( I swear I saw the
CC net/ipv6/ip6mr.o
line when building one...
Argh :( I didn't turn the CONFIG_IP_PIMSM on and all statistics
happened to be under this option only.
> I've fixed it up as below.
>
> UGH, the ipv4 ipmr patch has the same problem, I'll fix that up to :-(
Thank you. Sorry for bad patchset :(
> ip6mr: Use on-device stats instead of private ones.
>
> Similar to ipmr.
>
> [ Fix build failures -DaveM ]
>
> Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
> Signed-off-by: David S. Miller <davem@davemloft.net>
prev parent reply other threads:[~2008-05-22 8:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-21 21:42 build failure from ip6mr stats change David Miller
2008-05-22 8:32 ` Pavel Emelyanov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48352F80.6010708@openvz.org \
--to=xemul@openvz.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).