* [PATCH] e1000e: use resource_size_t, not unsigned long, for phys addrs
@ 2008-05-01 23:03 Becky Bruce
2008-05-01 23:53 ` Kok, Auke
2008-05-22 10:22 ` Jeff Garzik
0 siblings, 2 replies; 3+ messages in thread
From: Becky Bruce @ 2008-05-01 23:03 UTC (permalink / raw)
To: jgarzik, auke-jan.h.kok; +Cc: e1000-devel, netdev
The use of unsigned long causes the driver to fail on 32-bit systems
which support 64-bit resources.
Signed-off-by: Becky Bruce <becky.bruce@freescale.com>
---
Resend, with proper CC.
drivers/net/e1000e/netdev.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/e1000e/netdev.c b/drivers/net/e1000e/netdev.c
index 8991ab8..dae3269 100644
--- a/drivers/net/e1000e/netdev.c
+++ b/drivers/net/e1000e/netdev.c
@@ -3897,8 +3897,8 @@ static int __devinit e1000_probe(struct pci_dev *pdev,
struct e1000_adapter *adapter;
struct e1000_hw *hw;
const struct e1000_info *ei = e1000_info_tbl[ent->driver_data];
- unsigned long mmio_start, mmio_len;
- unsigned long flash_start, flash_len;
+ resource_size_t mmio_start, mmio_len;
+ resource_size_t flash_start, flash_len;
static int cards_found;
int i, err, pci_using_dac;
--
1.5.4.1
-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference
Don't miss this year's exciting event. There's still time to save $100.
Use priority code J8TL2D2.
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] e1000e: use resource_size_t, not unsigned long, for phys addrs
2008-05-01 23:03 [PATCH] e1000e: use resource_size_t, not unsigned long, for phys addrs Becky Bruce
@ 2008-05-01 23:53 ` Kok, Auke
2008-05-22 10:22 ` Jeff Garzik
1 sibling, 0 replies; 3+ messages in thread
From: Kok, Auke @ 2008-05-01 23:53 UTC (permalink / raw)
To: Becky Bruce, jgarzik; +Cc: auke-jan.h.kok, netdev, e1000-devel
Becky Bruce wrote:
> The use of unsigned long causes the driver to fail on 32-bit systems
> which support 64-bit resources.
>
> Signed-off-by: Becky Bruce <becky.bruce@freescale.com>
Acked-by: Auke Kok <auke-jan.h.kok@intel.com>
thanks Becky,
Auke
> ---
>
> Resend, with proper CC.
>
> drivers/net/e1000e/netdev.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/e1000e/netdev.c b/drivers/net/e1000e/netdev.c
> index 8991ab8..dae3269 100644
> --- a/drivers/net/e1000e/netdev.c
> +++ b/drivers/net/e1000e/netdev.c
> @@ -3897,8 +3897,8 @@ static int __devinit e1000_probe(struct pci_dev *pdev,
> struct e1000_adapter *adapter;
> struct e1000_hw *hw;
> const struct e1000_info *ei = e1000_info_tbl[ent->driver_data];
> - unsigned long mmio_start, mmio_len;
> - unsigned long flash_start, flash_len;
> + resource_size_t mmio_start, mmio_len;
> + resource_size_t flash_start, flash_len;
>
> static int cards_found;
> int i, err, pci_using_dac;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] e1000e: use resource_size_t, not unsigned long, for phys addrs
2008-05-01 23:03 [PATCH] e1000e: use resource_size_t, not unsigned long, for phys addrs Becky Bruce
2008-05-01 23:53 ` Kok, Auke
@ 2008-05-22 10:22 ` Jeff Garzik
1 sibling, 0 replies; 3+ messages in thread
From: Jeff Garzik @ 2008-05-22 10:22 UTC (permalink / raw)
To: Becky Bruce; +Cc: auke-jan.h.kok, netdev, e1000-devel
Becky Bruce wrote:
> The use of unsigned long causes the driver to fail on 32-bit systems
> which support 64-bit resources.
>
> Signed-off-by: Becky Bruce <becky.bruce@freescale.com>
> ---
>
> Resend, with proper CC.
>
> drivers/net/e1000e/netdev.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/e1000e/netdev.c b/drivers/net/e1000e/netdev.c
> index 8991ab8..dae3269 100644
> --- a/drivers/net/e1000e/netdev.c
> +++ b/drivers/net/e1000e/netdev.c
> @@ -3897,8 +3897,8 @@ static int __devinit e1000_probe(struct pci_dev *pdev,
> struct e1000_adapter *adapter;
> struct e1000_hw *hw;
> const struct e1000_info *ei = e1000_info_tbl[ent->driver_data];
> - unsigned long mmio_start, mmio_len;
> - unsigned long flash_start, flash_len;
> + resource_size_t mmio_start, mmio_len;
> + resource_size_t flash_start, flash_len;
>
applied
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-05-22 10:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-05-01 23:03 [PATCH] e1000e: use resource_size_t, not unsigned long, for phys addrs Becky Bruce
2008-05-01 23:53 ` Kok, Auke
2008-05-22 10:22 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).