From: Patrick McHardy <kaber@trash.net>
To: "Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@intel.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [RFC, VLAN]: Propagate selected feature bits to VLAN devices
Date: Thu, 22 May 2008 20:03:02 +0200 [thread overview]
Message-ID: <4835B556.4020308@trash.net> (raw)
In-Reply-To: <D5C1322C3E673F459512FB59E0DDC329051F36F5@orsmsx414.amr.corp.intel.com>
Waskiewicz Jr, Peter P wrote:
>>> I thought about this myself, my second idea was to add a mask for
>>> feature bits to be propagated. Unless there is a need for
>>>
>> the driver
>>
>>> to determine them at runtime, thats slightly simpler. The
>>>
>> driver would
>>
>>> do:
>>>
>>> dev->vlan_features = NETIF_F_CSUM_ALL | ...
>>>
>>> What do you think about this?
>>>
>> Yes that sounds great!
>>
>
> The issue is how does the driver know how to pull those flags off the
> VLAN device when the parent has TSO or CSUM offload disabled? The only
> way I could come up with it was in my original patch in the drivers to
> loop through the entire VLAN group array, and clear the flag on existing
> devices.
>
Yes, thats also what my patch is doing. Not a big deal I guess,
we're doing that for all kinds of notifications already and
nobody ever complained.
next prev parent reply other threads:[~2008-05-22 18:04 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-20 14:37 [RFC, VLAN]: Propagate selected feature bits to VLAN devices Patrick McHardy
2008-05-20 14:38 ` Patrick McHardy
2008-05-20 14:48 ` Ben Hutchings
2008-05-20 14:51 ` Patrick McHardy
2008-05-20 15:46 ` Ben Greear
2008-05-20 16:20 ` Ben Hutchings
2008-05-20 16:27 ` Patrick McHardy
2008-05-20 16:28 ` Ben Greear
2008-05-20 17:22 ` Waskiewicz Jr, Peter P
2008-05-20 17:23 ` Patrick McHardy
2008-05-20 18:05 ` Ben Hutchings
2008-05-20 18:31 ` Patrick McHardy
2008-05-20 19:58 ` Waskiewicz Jr, Peter P
2008-05-20 23:59 ` Patrick McHardy
2008-05-20 21:55 ` David Miller
2008-05-20 23:58 ` Patrick McHardy
2008-05-21 15:49 ` Herbert Xu
2008-05-21 16:28 ` Patrick McHardy
2008-05-21 23:39 ` Herbert Xu
2008-05-22 17:47 ` Waskiewicz Jr, Peter P
2008-05-22 18:03 ` Patrick McHardy [this message]
2008-05-22 18:18 ` Waskiewicz Jr, Peter P
2008-05-22 18:25 ` Patrick McHardy
2008-05-22 18:57 ` Waskiewicz Jr, Peter P
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4835B556.4020308@trash.net \
--to=kaber@trash.net \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
--cc=peter.p.waskiewicz.jr@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).