[PATCH] ucc_geth_ethtool: Fix a few HW stats counters.

[PATCH] ucc_geth_ethtool: Fix a few HW stats counters.

[Joakim Tjernlund]

Noticed that ethtool -S didn't display tx-xxx-frames correctly.
Fix it and a few others while I am there. Strangely, the
rx-jumbo-frames counter still counts pkgs even though I think
there isn't any packtes above 1518.

Signed-off-by: Joakim Tjernlund <Joakim.Tjernlund@transmode.se>
---

Havn't seen this go in or ACK/NACK. Resending.

 drivers/net/ucc_geth_ethtool.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ucc_geth_ethtool.c b/drivers/net/ucc_geth_ethtool.c
index a995a3a..0eddf50 100644
--- a/drivers/net/ucc_geth_ethtool.c
+++ b/drivers/net/ucc_geth_ethtool.c
@@ -60,7 +60,6 @@ static char hw_stat_gstrings[][ETH_GSTRING_LEN] = {
 	"rx-broadcast-frames",
 	"stats-counter-carry",
 	"stats-counter-mask",
-	"rx-dropped-frames",
 };
 
 static char tx_fw_stat_gstrings[][ETH_GSTRING_LEN] = {
@@ -73,6 +72,7 @@ static char tx_fw_stat_gstrings[][ETH_GSTRING_LEN] = {
 	"tx-frames-ok",
 	"tx-excessive-differ-frames",
 	"tx-256-511-frames",
+	"tx-512-1023-frames",
 	"tx-1024-1518-frames",
 	"tx-jumbo-frames",
 };
@@ -101,7 +101,6 @@ static char rx_fw_stat_gstrings[][ETH_GSTRING_LEN] = {
 	"rx-vlan-removed",
 	"rx-vlan-replaced",
 	"rx-vlan-inserted",
-	"rx-ip-checksum-errors",
 };
 
 #define UEC_HW_STATS_LEN ARRAY_SIZE(hw_stat_gstrings)
-- 
1.5.5.1

RE: [PATCH] ucc_geth_ethtool: Fix a few HW stats counters.

[Li Yang]

Hi Joakim,

I admit that I missed one in tx firmware stats.  But why are you
deleting the other two?

- Leo

> -----Original Message-----
> From: Joakim Tjernlund [mailto:Joakim.Tjernlund@transmode.se] 
> Sent: Tuesday, May 13, 2008 4:05 PM
> To: Netdev; Li Yang
> Cc: Joakim Tjernlund
> Subject: [PATCH] ucc_geth_ethtool: Fix a few HW stats counters.
> 
> Noticed that ethtool -S didn't display tx-xxx-frames correctly.
> Fix it and a few others while I am there. Strangely, the 
> rx-jumbo-frames counter still counts pkgs even though I think 
> there isn't any packtes above 1518.
> 
> Signed-off-by: Joakim Tjernlund <Joakim.Tjernlund@transmode.se>
> ---
> 
> Havn't seen this go in or ACK/NACK. Resending.
> 
>  drivers/net/ucc_geth_ethtool.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ucc_geth_ethtool.c 
> b/drivers/net/ucc_geth_ethtool.c index a995a3a..0eddf50 100644
> --- a/drivers/net/ucc_geth_ethtool.c
> +++ b/drivers/net/ucc_geth_ethtool.c
> @@ -60,7 +60,6 @@ static char hw_stat_gstrings[][ETH_GSTRING_LEN] = {
>  	"rx-broadcast-frames",
>  	"stats-counter-carry",
>  	"stats-counter-mask",
> -	"rx-dropped-frames",
>  };
>  
>  static char tx_fw_stat_gstrings[][ETH_GSTRING_LEN] = { @@ 
> -73,6 +72,7 @@ static char tx_fw_stat_gstrings[][ETH_GSTRING_LEN] = {
>  	"tx-frames-ok",
>  	"tx-excessive-differ-frames",
>  	"tx-256-511-frames",
> +	"tx-512-1023-frames",
>  	"tx-1024-1518-frames",
>  	"tx-jumbo-frames",
>  };
> @@ -101,7 +101,6 @@ static char 
> rx_fw_stat_gstrings[][ETH_GSTRING_LEN] = {
>  	"rx-vlan-removed",
>  	"rx-vlan-replaced",
>  	"rx-vlan-inserted",
> -	"rx-ip-checksum-errors",
>  };
>  
>  #define UEC_HW_STATS_LEN ARRAY_SIZE(hw_stat_gstrings)
> --
> 1.5.5.1
> 
> 

RE: [PATCH] ucc_geth_ethtool: Fix a few HW stats counters.

[Joakim Tjernlund]

I didn't see them in my manual so I figured they were extra. If you find
them please let me know where.

On Wed, 2008-05-14 at 18:37 +0800, Li Yang wrote:
> Hi Joakim,
> 
> I admit that I missed one in tx firmware stats.  But why are you
> deleting the other two?
> 
> - Leo
> 
> > -----Original Message-----
> > From: Joakim Tjernlund [mailto:Joakim.Tjernlund@transmode.se] 
> > Sent: Tuesday, May 13, 2008 4:05 PM
> > To: Netdev; Li Yang
> > Cc: Joakim Tjernlund
> > Subject: [PATCH] ucc_geth_ethtool: Fix a few HW stats counters.
> > 
> > Noticed that ethtool -S didn't display tx-xxx-frames correctly.
> > Fix it and a few others while I am there. Strangely, the 
> > rx-jumbo-frames counter still counts pkgs even though I think 
> > there isn't any packtes above 1518.
> > 
> > Signed-off-by: Joakim Tjernlund <Joakim.Tjernlund@transmode.se>
> > ---
> > 
> > Havn't seen this go in or ACK/NACK. Resending.
> > 
> >  drivers/net/ucc_geth_ethtool.c |    3 +--
> >  1 files changed, 1 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/net/ucc_geth_ethtool.c 
> > b/drivers/net/ucc_geth_ethtool.c index a995a3a..0eddf50 100644
> > --- a/drivers/net/ucc_geth_ethtool.c
> > +++ b/drivers/net/ucc_geth_ethtool.c
> > @@ -60,7 +60,6 @@ static char hw_stat_gstrings[][ETH_GSTRING_LEN] = {
> >  	"rx-broadcast-frames",
> >  	"stats-counter-carry",
> >  	"stats-counter-mask",
> > -	"rx-dropped-frames",
> >  };
> >  
> >  static char tx_fw_stat_gstrings[][ETH_GSTRING_LEN] = { @@ 
> > -73,6 +72,7 @@ static char tx_fw_stat_gstrings[][ETH_GSTRING_LEN] = {
> >  	"tx-frames-ok",
> >  	"tx-excessive-differ-frames",
> >  	"tx-256-511-frames",
> > +	"tx-512-1023-frames",
> >  	"tx-1024-1518-frames",
> >  	"tx-jumbo-frames",
> >  };
> > @@ -101,7 +101,6 @@ static char 
> > rx_fw_stat_gstrings[][ETH_GSTRING_LEN] = {
> >  	"rx-vlan-removed",
> >  	"rx-vlan-replaced",
> >  	"rx-vlan-inserted",
> > -	"rx-ip-checksum-errors",
> >  };
> >  
> >  #define UEC_HW_STATS_LEN ARRAY_SIZE(hw_stat_gstrings)
> > --
> > 1.5.5.1
> > 
> > 
> 
> 

RE: [PATCH] ucc_geth_ethtool: Fix a few HW stats counters.

[Li Yang]

> -----Original Message-----
> From: Joakim Tjernlund [mailto:joakim.tjernlund@transmode.se] 
> Sent: Wednesday, May 14, 2008 6:50 PM
> To: Li Yang
> Cc: Netdev
> Subject: RE: [PATCH] ucc_geth_ethtool: Fix a few HW stats counters.
> 
> I didn't see them in my manual so I figured they were extra. 
> If you find them please let me know where.

I'm reading from MPC8360ERM Rev. 2.  They have the following definition:

UCCx_BASE+0x1C4  Frames discarded due to overrun condition in the
RxFIFO.
REBASE+5C Counts the total number of fames that have an IPChecsum Error.

Which manual are you using?

- Leo
> 
> On Wed, 2008-05-14 at 18:37 +0800, Li Yang wrote:
> > Hi Joakim,
> > 
> > I admit that I missed one in tx firmware stats.  But why are you 
> > deleting the other two?
> > 
> > - Leo
> > 
> > > -----Original Message-----
> > > From: Joakim Tjernlund [mailto:Joakim.Tjernlund@transmode.se]
> > > Sent: Tuesday, May 13, 2008 4:05 PM
> > > To: Netdev; Li Yang
> > > Cc: Joakim Tjernlund
> > > Subject: [PATCH] ucc_geth_ethtool: Fix a few HW stats counters.
> > > 
> > > Noticed that ethtool -S didn't display tx-xxx-frames correctly.
> > > Fix it and a few others while I am there. Strangely, the 
> > > rx-jumbo-frames counter still counts pkgs even though I 
> think there 
> > > isn't any packtes above 1518.
> > > 
> > > Signed-off-by: Joakim Tjernlund <Joakim.Tjernlund@transmode.se>
> > > ---
> > > 
> > > Havn't seen this go in or ACK/NACK. Resending.
> > > 
> > >  drivers/net/ucc_geth_ethtool.c |    3 +--
> > >  1 files changed, 1 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/drivers/net/ucc_geth_ethtool.c 
> > > b/drivers/net/ucc_geth_ethtool.c index a995a3a..0eddf50 100644
> > > --- a/drivers/net/ucc_geth_ethtool.c
> > > +++ b/drivers/net/ucc_geth_ethtool.c
> > > @@ -60,7 +60,6 @@ static char 
> hw_stat_gstrings[][ETH_GSTRING_LEN] = {
> > >  	"rx-broadcast-frames",
> > >  	"stats-counter-carry",
> > >  	"stats-counter-mask",
> > > -	"rx-dropped-frames",
> > >  };
> > >  
> > >  static char tx_fw_stat_gstrings[][ETH_GSTRING_LEN] = { @@
> > > -73,6 +72,7 @@ static char 
> tx_fw_stat_gstrings[][ETH_GSTRING_LEN] = {
> > >  	"tx-frames-ok",
> > >  	"tx-excessive-differ-frames",
> > >  	"tx-256-511-frames",
> > > +	"tx-512-1023-frames",
> > >  	"tx-1024-1518-frames",
> > >  	"tx-jumbo-frames",
> > >  };
> > > @@ -101,7 +101,6 @@ static char
> > > rx_fw_stat_gstrings[][ETH_GSTRING_LEN] = {
> > >  	"rx-vlan-removed",
> > >  	"rx-vlan-replaced",
> > >  	"rx-vlan-inserted",
> > > -	"rx-ip-checksum-errors",
> > >  };
> > >  
> > >  #define UEC_HW_STATS_LEN ARRAY_SIZE(hw_stat_gstrings)
> > > --
> > > 1.5.5.1
> > > 
> > > 
> > 
> > 
> 

Re: [PATCH] ucc_geth_ethtool: Fix a few HW stats counters.

[Jeff Garzik]

Joakim Tjernlund wrote:
> Noticed that ethtool -S didn't display tx-xxx-frames correctly.
> Fix it and a few others while I am there. Strangely, the
> rx-jumbo-frames counter still counts pkgs even though I think
> there isn't any packtes above 1518.
> 
> Signed-off-by: Joakim Tjernlund <Joakim.Tjernlund@transmode.se>
> ---
> 
> Havn't seen this go in or ACK/NACK. Resending.
> 
>  drivers/net/ucc_geth_ethtool.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)

still looking for maintainer's ack...

RE: [PATCH] ucc_geth_ethtool: Fix a few HW stats counters.

[Li Yang]

> -----Original Message-----
> From: Jeff Garzik [mailto:jeff@garzik.org] 
> Sent: Friday, May 23, 2008 2:06 AM
> To: Joakim Tjernlund
> Cc: Netdev; Li Yang
> Subject: Re: [PATCH] ucc_geth_ethtool: Fix a few HW stats counters.
> 
> Joakim Tjernlund wrote:
> > Noticed that ethtool -S didn't display tx-xxx-frames correctly.
> > Fix it and a few others while I am there. Strangely, the 
> > rx-jumbo-frames counter still counts pkgs even though I think there 
> > isn't any packtes above 1518.
> > 
> > Signed-off-by: Joakim Tjernlund <Joakim.Tjernlund@transmode.se>
> > ---
> > 
> > Havn't seen this go in or ACK/NACK. Resending.
> > 
> >  drivers/net/ucc_geth_ethtool.c |    3 +--
> >  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> still looking for maintainer's ack...

This patch still need some change.

Joakim,

Could you respin this patch without deleting the two counters?

- Leo

RE: [PATCH] ucc_geth_ethtool: Fix a few HW stats counters.

[Joakim Tjernlund]

On Fri, 2008-05-23 at 11:04 +0800, Li Yang wrote:
> > -----Original Message-----
> > From: Jeff Garzik [mailto:jeff@garzik.org] 
> > Sent: Friday, May 23, 2008 2:06 AM
> > To: Joakim Tjernlund
> > Cc: Netdev; Li Yang
> > Subject: Re: [PATCH] ucc_geth_ethtool: Fix a few HW stats counters.
> > 
> > Joakim Tjernlund wrote:
> > > Noticed that ethtool -S didn't display tx-xxx-frames correctly.
> > > Fix it and a few others while I am there. Strangely, the 
> > > rx-jumbo-frames counter still counts pkgs even though I think there 
> > > isn't any packtes above 1518.
> > > 
> > > Signed-off-by: Joakim Tjernlund <Joakim.Tjernlund@transmode.se>
> > > ---
> > > 
> > > Havn't seen this go in or ACK/NACK. Resending.
> > > 
> > >  drivers/net/ucc_geth_ethtool.c |    3 +--
> > >  1 files changed, 1 insertions(+), 2 deletions(-)
> > 
> > still looking for maintainer's ack...
> 
> This patch still need some change.
> 
> Joakim,
> 
> Could you respin this patch without deleting the two counters?

Very busy ATM, release coming up here so I need to focus on that.
Feel free to respin yourself meanwhile.

RE: [PATCH] ucc_geth_ethtool: Fix a few HW stats counters.

[Li Yang]

> -----Original Message-----
> From: Joakim Tjernlund [mailto:joakim.tjernlund@transmode.se] 
> Sent: Friday, May 23, 2008 3:21 PM
> To: Li Yang
> Cc: Jeff Garzik; Netdev
> Subject: RE: [PATCH] ucc_geth_ethtool: Fix a few HW stats counters.
> 
> 
> On Fri, 2008-05-23 at 11:04 +0800, Li Yang wrote:
> > > -----Original Message-----
> > > From: Jeff Garzik [mailto:jeff@garzik.org]
> > > Sent: Friday, May 23, 2008 2:06 AM
> > > To: Joakim Tjernlund
> > > Cc: Netdev; Li Yang
> > > Subject: Re: [PATCH] ucc_geth_ethtool: Fix a few HW stats 
> counters.
> > > 
> > > Joakim Tjernlund wrote:
> > > > Noticed that ethtool -S didn't display tx-xxx-frames correctly.
> > > > Fix it and a few others while I am there. Strangely, the 
> > > > rx-jumbo-frames counter still counts pkgs even though I think 
> > > > there isn't any packtes above 1518.
> > > > 
> > > > Signed-off-by: Joakim Tjernlund <Joakim.Tjernlund@transmode.se>
> > > > ---
> > > > 
> > > > Havn't seen this go in or ACK/NACK. Resending.
> > > > 
> > > >  drivers/net/ucc_geth_ethtool.c |    3 +--
> > > >  1 files changed, 1 insertions(+), 2 deletions(-)
> > > 
> > > still looking for maintainer's ack...
> > 
> > This patch still need some change.
> > 
> > Joakim,
> > 
> > Could you respin this patch without deleting the two counters?
> 
> Very busy ATM, release coming up here so I need to focus on that.
> Feel free to respin yourself meanwhile.

Sure. I will do it.  Thanks

[PATCH] ucc_geth_ethtool: Fix a few HW stats counters.

[Joakim Tjernlund]

Noticed that ethtool -S didn't display tx-xxx-frames correctly.
Fix it and a few others while I am there. Strangely, the
rx-jumbo-frames counter still counts pkgs even though I think
there isn't any packtes above 1518.

Signed-off-by: Joakim Tjernlund <Joakim.Tjernlund@transmode.se>
---
 drivers/net/ucc_geth_ethtool.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ucc_geth_ethtool.c b/drivers/net/ucc_geth_ethtool.c
index a995a3a..0eddf50 100644
--- a/drivers/net/ucc_geth_ethtool.c
+++ b/drivers/net/ucc_geth_ethtool.c
@@ -60,7 +60,6 @@ static char hw_stat_gstrings[][ETH_GSTRING_LEN] = {
 	"rx-broadcast-frames",
 	"stats-counter-carry",
 	"stats-counter-mask",
-	"rx-dropped-frames",
 };
 
 static char tx_fw_stat_gstrings[][ETH_GSTRING_LEN] = {
@@ -73,6 +72,7 @@ static char tx_fw_stat_gstrings[][ETH_GSTRING_LEN] = {
 	"tx-frames-ok",
 	"tx-excessive-differ-frames",
 	"tx-256-511-frames",
+	"tx-512-1023-frames",
 	"tx-1024-1518-frames",
 	"tx-jumbo-frames",
 };
@@ -101,7 +101,6 @@ static char rx_fw_stat_gstrings[][ETH_GSTRING_LEN] = {
 	"rx-vlan-removed",
 	"rx-vlan-replaced",
 	"rx-vlan-inserted",
-	"rx-ip-checksum-errors",
 };
 
 #define UEC_HW_STATS_LEN ARRAY_SIZE(hw_stat_gstrings)
-- 
1.5.5.1