From: Ivan Vecera <ivecera@redhat.com>
To: Ben Hutchings <bhutchings@solarflare.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, aabdulla@nvidia.com,
Ben Hutchings <ben@decadent.org.uk>,
Francois Romieu <romieu@fr.zoreil.com>
Subject: Re: [PATCH] drivers/net: Call netif_carrier_off at the end of the probe
Date: Tue, 15 Feb 2011 13:01:03 -0500 (EST) [thread overview]
Message-ID: <483985247.35721.1297792863958.JavaMail.root@zmail07.collab.prod.int.phx2.redhat.com> (raw)
In-Reply-To: <1297785532.2584.10.camel@bwh-desktop>
----- Original Message -----
> On Tue, 2011-02-15 at 16:22 +0100, Francois Romieu wrote:
> > Stated this way it sounds like a core dev layer issue.
>
> ...
> > I am not completely sure after reading some history. Namely:
> > - (37e8273cd30592d3a82bcb70cbb1bdc4eaeb6b71 ?)
> > - c276e098d3ee33059b4a1c747354226cec58487c
> > - 22604c866889c4b2e12b73cbf1683bda1b72a313
> > - b47300168e770b60ab96c8924854c3b0eb4260eb
> >
> > I am confused.
>
> Drivers that can report carrier state should do so initially some time
> between registering a device and bringing it up (either in the bus
> probe
> function or the ndo_open function). It generally seems to be safe to
> assume that the link is down initially, and then to rely on
> notifications from the hardware. However, that does depend on the
> behaviour of the hardware.
>
Yes,that's true... forcedeth and r8169 are the drivers that detect link
state when device is opened and call netif_carrier_on(off) appropriately.
Ivan
next prev parent reply other threads:[~2011-02-15 18:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-15 12:08 [PATCH] drivers/net: Call netif_carrier_off at the end of the probe Ivan Vecera
2011-02-15 15:22 ` Francois Romieu
2011-02-15 15:58 ` Ben Hutchings
2011-02-15 18:01 ` Ivan Vecera [this message]
2011-02-17 8:24 ` Ivan Vecera
2011-02-17 10:19 ` Francois Romieu
2011-02-17 10:32 ` Ivan Vecera
2011-02-17 13:15 ` Francois Romieu
2011-02-17 22:10 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=483985247.35721.1297792863958.JavaMail.root@zmail07.collab.prod.int.phx2.redhat.com \
--to=ivecera@redhat.com \
--cc=aabdulla@nvidia.com \
--cc=ben@decadent.org.uk \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).