netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Dmitry Petukhov <dmgenp@gmail.com>
Cc: linux-kernel@vger.kernel.org, Linux Netdev List <netdev@vger.kernel.org>
Subject: Re: possible double call of kfree_skb in net/llc/llc_sap.c
Date: Tue, 27 May 2008 08:16:11 +0200	[thread overview]
Message-ID: <483BA72B.5010207@trash.net> (raw)
In-Reply-To: <84ee89da0805262300v747c712ayfb60ac8aa790edb7@mail.gmail.com>

Dmitry Petukhov wrote:
> In the file  net/llc/llc_sap.c, funcion llc_sap_state_process,
> the call to kfree_skb in the line 227 can proceed even if skb was already freed
> on line 218, or  224, or queued to the user within sock_queue_rcv_skb function.
> Obviously return statement is missing after line 225.
> 
> This problem was found by Alex Shevkov.

Could you send a patch please?

       reply	other threads:[~2008-05-27  6:16 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <84ee89da0805262300v747c712ayfb60ac8aa790edb7@mail.gmail.com>
2008-05-27  6:16 ` Patrick McHardy [this message]
2008-05-27  6:20   ` possible double call of kfree_skb in net/llc/llc_sap.c Pekka Enberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=483BA72B.5010207@trash.net \
    --to=kaber@trash.net \
    --cc=dmgenp@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).