* Re: possible double call of kfree_skb in net/llc/llc_sap.c
[not found] <84ee89da0805262300v747c712ayfb60ac8aa790edb7@mail.gmail.com>
@ 2008-05-27 6:16 ` Patrick McHardy
2008-05-27 6:20 ` Pekka Enberg
0 siblings, 1 reply; 2+ messages in thread
From: Patrick McHardy @ 2008-05-27 6:16 UTC (permalink / raw)
To: Dmitry Petukhov; +Cc: linux-kernel, Linux Netdev List
Dmitry Petukhov wrote:
> In the file net/llc/llc_sap.c, funcion llc_sap_state_process,
> the call to kfree_skb in the line 227 can proceed even if skb was already freed
> on line 218, or 224, or queued to the user within sock_queue_rcv_skb function.
> Obviously return statement is missing after line 225.
>
> This problem was found by Alex Shevkov.
Could you send a patch please?
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: possible double call of kfree_skb in net/llc/llc_sap.c
2008-05-27 6:16 ` possible double call of kfree_skb in net/llc/llc_sap.c Patrick McHardy
@ 2008-05-27 6:20 ` Pekka Enberg
0 siblings, 0 replies; 2+ messages in thread
From: Pekka Enberg @ 2008-05-27 6:20 UTC (permalink / raw)
To: Patrick McHardy; +Cc: Dmitry Petukhov, linux-kernel, Linux Netdev List
Dmitry Petukhov wrote:
>> In the file net/llc/llc_sap.c, funcion llc_sap_state_process,
>> the call to kfree_skb in the line 227 can proceed even if skb was already
>> freed
>> on line 218, or 224, or queued to the user within sock_queue_rcv_skb
>> function.
>> Obviously return statement is missing after line 225.
>>
>> This problem was found by Alex Shevkov.
On Tue, May 27, 2008 at 9:16 AM, Patrick McHardy <kaber@trash.net> wrote:
> Could you send a patch please?
I wonder how the code got in that shape but it's probably best to just
remove the extra kfree_skb() calls and do it unconditionally at the
end of the function.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-05-27 6:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <84ee89da0805262300v747c712ayfb60ac8aa790edb7@mail.gmail.com>
2008-05-27 6:16 ` possible double call of kfree_skb in net/llc/llc_sap.c Patrick McHardy
2008-05-27 6:20 ` Pekka Enberg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).