* [PATCH] sc92031: remove bogus unlikely()
@ 2008-05-30 0:58 Cesar Eduardo Barros
2008-05-31 2:12 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Cesar Eduardo Barros @ 2008-05-30 0:58 UTC (permalink / raw)
To: Jeff Garzik; +Cc: netdev
Commit 5a0a92e67b5009a71e011658da04fb92dad8961f mentions len < ETH_ZLEN
is true for ARP packets. This obviously is not unlikely.
Signed-off-by: Cesar Eduardo Barros <cesarb@cesarb.net>
---
drivers/net/sc92031.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/sc92031.c b/drivers/net/sc92031.c
index b4b6380..61955f8 100644
--- a/drivers/net/sc92031.c
+++ b/drivers/net/sc92031.c
@@ -972,7 +972,7 @@ static int sc92031_start_xmit(struct sk_buff *skb, struct net_device *dev)
skb_copy_and_csum_dev(skb, priv->tx_bufs + entry * TX_BUF_SIZE);
len = skb->len;
- if (unlikely(len < ETH_ZLEN)) {
+ if (len < ETH_ZLEN) {
memset(priv->tx_bufs + entry * TX_BUF_SIZE + len,
0, ETH_ZLEN - len);
len = ETH_ZLEN;
--
1.5.5.1
--
Cesar Eduardo Barros
cesarb@cesarb.net
cesar.barros@gmail.com
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] sc92031: remove bogus unlikely()
2008-05-30 0:58 [PATCH] sc92031: remove bogus unlikely() Cesar Eduardo Barros
@ 2008-05-31 2:12 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2008-05-31 2:12 UTC (permalink / raw)
To: Cesar Eduardo Barros; +Cc: netdev
Cesar Eduardo Barros wrote:
> Commit 5a0a92e67b5009a71e011658da04fb92dad8961f mentions len < ETH_ZLEN
> is true for ARP packets. This obviously is not unlikely.
>
> Signed-off-by: Cesar Eduardo Barros <cesarb@cesarb.net>
> ---
> drivers/net/sc92031.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/sc92031.c b/drivers/net/sc92031.c
> index b4b6380..61955f8 100644
> --- a/drivers/net/sc92031.c
> +++ b/drivers/net/sc92031.c
> @@ -972,7 +972,7 @@ static int sc92031_start_xmit(struct sk_buff *skb, struct net_device *dev)
> skb_copy_and_csum_dev(skb, priv->tx_bufs + entry * TX_BUF_SIZE);
>
> len = skb->len;
> - if (unlikely(len < ETH_ZLEN)) {
> + if (len < ETH_ZLEN) {
> memset(priv->tx_bufs + entry * TX_BUF_SIZE + len,
applied
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-05-31 2:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-05-30 0:58 [PATCH] sc92031: remove bogus unlikely() Cesar Eduardo Barros
2008-05-31 2:12 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).