From: Jeff Garzik <jgarzik@pobox.com>
To: Cesar Eduardo Barros <cesarb@cesarb.net>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] sc92031: remove bogus unlikely()
Date: Fri, 30 May 2008 22:12:52 -0400 [thread overview]
Message-ID: <4840B424.8060308@pobox.com> (raw)
In-Reply-To: <483F513C.5010303@cesarb.net>
Cesar Eduardo Barros wrote:
> Commit 5a0a92e67b5009a71e011658da04fb92dad8961f mentions len < ETH_ZLEN
> is true for ARP packets. This obviously is not unlikely.
>
> Signed-off-by: Cesar Eduardo Barros <cesarb@cesarb.net>
> ---
> drivers/net/sc92031.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/sc92031.c b/drivers/net/sc92031.c
> index b4b6380..61955f8 100644
> --- a/drivers/net/sc92031.c
> +++ b/drivers/net/sc92031.c
> @@ -972,7 +972,7 @@ static int sc92031_start_xmit(struct sk_buff *skb, struct net_device *dev)
> skb_copy_and_csum_dev(skb, priv->tx_bufs + entry * TX_BUF_SIZE);
>
> len = skb->len;
> - if (unlikely(len < ETH_ZLEN)) {
> + if (len < ETH_ZLEN) {
> memset(priv->tx_bufs + entry * TX_BUF_SIZE + len,
applied
prev parent reply other threads:[~2008-05-31 2:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-30 0:58 [PATCH] sc92031: remove bogus unlikely() Cesar Eduardo Barros
2008-05-31 2:12 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4840B424.8060308@pobox.com \
--to=jgarzik@pobox.com \
--cc=cesarb@cesarb.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).