* [PATCH] sfc: Report XAUI link down at default log level
@ 2008-05-30 21:18 Ben Hutchings
2008-05-31 2:13 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Ben Hutchings @ 2008-05-30 21:18 UTC (permalink / raw)
To: Jeff Garzik; +Cc: netdev, linux-net-drivers
This is normal when the external link is down so don't report it as an error.
Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
---
drivers/net/sfc/falcon_xmac.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/sfc/falcon_xmac.c b/drivers/net/sfc/falcon_xmac.c
index 264e1ee..37d3cae 100644
--- a/drivers/net/sfc/falcon_xmac.c
+++ b/drivers/net/sfc/falcon_xmac.c
@@ -513,7 +513,7 @@ static int falcon_check_xaui_link_up(struct efx_nic *efx)
tries--;
}
- EFX_ERR(efx, "Failed to bring XAUI link back up in %d tries!\n",
+ EFX_LOG(efx, "Failed to bring XAUI link back up in %d tries!\n",
max_tries);
return 0;
}
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] sfc: Report XAUI link down at default log level
2008-05-30 21:18 [PATCH] sfc: Report XAUI link down at default log level Ben Hutchings
@ 2008-05-31 2:13 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2008-05-31 2:13 UTC (permalink / raw)
To: Ben Hutchings; +Cc: netdev, linux-net-drivers
Ben Hutchings wrote:
> This is normal when the external link is down so don't report it as an error.
>
> Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
> ---
> drivers/net/sfc/falcon_xmac.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/sfc/falcon_xmac.c b/drivers/net/sfc/falcon_xmac.c
> index 264e1ee..37d3cae 100644
> --- a/drivers/net/sfc/falcon_xmac.c
> +++ b/drivers/net/sfc/falcon_xmac.c
> @@ -513,7 +513,7 @@ static int falcon_check_xaui_link_up(struct efx_nic *efx)
> tries--;
> }
>
> - EFX_ERR(efx, "Failed to bring XAUI link back up in %d tries!\n",
> + EFX_LOG(efx, "Failed to bring XAUI link back up in %d tries!\n",
> max_tries);
applied
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-05-31 2:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-05-30 21:18 [PATCH] sfc: Report XAUI link down at default log level Ben Hutchings
2008-05-31 2:13 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).