From: Jeff Garzik <jgarzik@pobox.com>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: netdev <netdev@vger.kernel.org>,
divy@chelsio.com, linux-next@vger.kernel.org,
akpm <akpm@linux-foundation.org>
Subject: Re: [PATCH -next] cxgb3: fix build error when INET=n
Date: Fri, 30 May 2008 22:19:49 -0400 [thread overview]
Message-ID: <4840B5C5.2010206@pobox.com> (raw)
In-Reply-To: <20080530102919.ecd1fb27.randy.dunlap@oracle.com>
Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> cxgb3 uses lro_* functions and selects INET_LRO, but this doesn't help unless
> INET is already enabled, so make the driver depend on INET also.
>
> sge.c:(.text+0x9f09a): undefined reference to `lro_flush_all'
> sge.c:(.text+0x9f62f): undefined reference to `lro_receive_skb'
> sge.c:(.text+0x9f8a3): undefined reference to `lro_receive_frags'
> sge.c:(.text+0x9fbe0): undefined reference to `lro_vlan_hwaccel_receive_skb'
> sge.c:(.text+0x9ffcd): undefined reference to `lro_vlan_hwaccel_receive_frags'
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> ---
> drivers/net/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-next-20080530.orig/drivers/net/Kconfig
> +++ linux-next-20080530/drivers/net/Kconfig
> @@ -2407,7 +2407,7 @@ config CHELSIO_T1_NAPI
>
> config CHELSIO_T3
> tristate "Chelsio Communications T3 10Gb Ethernet support"
> - depends on PCI
> + depends on PCI && INET
> select FW_LOADER
> select INET_LRO
> help
> --
applied
prev parent reply other threads:[~2008-05-31 2:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-30 17:29 [PATCH -next] cxgb3: fix build error when INET=n Randy Dunlap
2008-05-30 21:57 ` Divy Le Ray
2008-05-31 2:19 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4840B5C5.2010206@pobox.com \
--to=jgarzik@pobox.com \
--cc=akpm@linux-foundation.org \
--cc=divy@chelsio.com \
--cc=linux-next@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).