From: Bill Gatliff <bgat@billgatliff.com>
To: Ben Hutchings <bhutchings@solarflare.com>
Cc: Steve Glendinning <steve.glendinning@smsc.com>,
netdev@vger.kernel.org, Michael.Hennerich@analog.com,
Enrik.Berkhan@ge.com, hennerich@blackfin.uclinux.org,
ian.saturley@smsc.com, uclinux-dist-devel@blackfin.uclinux.org,
catalin.marinas@arm.com, Bahadir Balban <Bahadir.Balban@arm.com>,
Dustin Mcintire <dustin@sensoria.com>
Subject: Re: [PATCH] SMSC LAN911x and LAN921x vendor driver
Date: Mon, 02 Jun 2008 11:09:58 -0500 [thread overview]
Message-ID: <48441B56.8080905@billgatliff.com> (raw)
In-Reply-To: <20080602155415.GA6192@solarflare.com>
Ben Hutchings wrote:
>> +static int smsc911x_phy_loopbacktest(struct smsc911x_data *pdata)
>> +{
>> + int result = 0;
>> + unsigned int i;
>> + unsigned int val;
>> + unsigned long flags;
>> +
>> + /* Initialise tx packet using broadcast destination address */
>> + for (i = 0; i < 6; i++)
>> + pdata->loopback_tx_pkt[i] = (char)0xFF;
>
> The cast to char is just noise.
Not sure. What about signed vs. unsigned?
b.g.
--
Bill Gatliff
bgat@billgatliff.com
next prev parent reply other threads:[~2008-06-02 16:38 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080515170728.GA3176@PTXN0038.genpitfi01.og.ge.com>
2008-05-19 12:34 ` [PATCH] SMSC LAN911x and LAN921x vendor driver Steve Glendinning
2008-05-19 15:27 ` [Uclinux-dist-devel] " Mike Frysinger
2008-05-19 15:45 ` Catalin Marinas
2008-05-19 15:50 ` Mike Frysinger
2008-05-19 15:55 ` Catalin Marinas
2008-05-19 16:24 ` Catalin Marinas
2008-05-19 19:06 ` Steve.Glendinning
2008-06-02 10:45 ` Steve Glendinning
2008-06-02 15:54 ` Ben Hutchings
2008-06-02 16:09 ` Bill Gatliff [this message]
2008-06-02 18:32 ` Peter Korsgaard
2008-06-02 18:30 ` Steve.Glendinning
2008-06-02 19:03 ` Ben Hutchings
2008-06-04 16:34 ` Steve.Glendinning
2008-06-02 18:47 ` Peter Korsgaard
2008-10-21 13:00 Steve Glendinning
-- strict thread matches above, loose matches on Subject: below --
2007-07-16 18:54 Steve Glendinning
2007-07-18 22:38 ` Jeff Garzik
2007-07-20 16:22 ` Steve.Glendinning
2007-07-29 20:53 ` Peter Korsgaard
2007-07-30 18:31 ` Steve.Glendinning
2007-08-01 22:27 ` Peter Korsgaard
2007-08-07 23:09 ` Peter Korsgaard
2006-12-30 16:34 Steve Glendinning
2007-01-04 14:42 ` Pierre TARDY
2006-12-04 22:31 Steve Glendinning
2006-07-28 21:38 Francois Romieu
2006-08-01 15:12 ` [PATCH] " Steve Glendinning
2006-08-01 15:33 ` John W. Linville
2006-08-02 19:23 ` Steve.Glendinning
2006-08-02 19:51 ` John W. Linville
2006-08-01 18:28 ` Scott Murray
2006-08-01 19:27 ` Steve.Glendinning
2006-08-01 23:51 ` Scott Murray
2006-08-03 15:26 ` Steve.Glendinning
2006-08-03 21:07 ` Scott Murray
2006-08-01 21:40 ` Francois Romieu
2006-08-02 19:39 ` Steve.Glendinning
2006-08-02 21:07 ` Francois Romieu
2006-08-04 11:29 ` Steve Glendinning
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48441B56.8080905@billgatliff.com \
--to=bgat@billgatliff.com \
--cc=Bahadir.Balban@arm.com \
--cc=Enrik.Berkhan@ge.com \
--cc=Michael.Hennerich@analog.com \
--cc=bhutchings@solarflare.com \
--cc=catalin.marinas@arm.com \
--cc=dustin@sensoria.com \
--cc=hennerich@blackfin.uclinux.org \
--cc=ian.saturley@smsc.com \
--cc=netdev@vger.kernel.org \
--cc=steve.glendinning@smsc.com \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).