From: Brian Haley <brian.haley@hp.com>
To: "YOSHIFUJI Hideaki / 吉藤英明" <yoshfuji@linux-ipv6.org>
Cc: shanwei@cn.fujitsu.com, davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH v2] IPv6: fix bug when specifying the non-exist outgoing interface
Date: Mon, 02 Jun 2008 13:39:10 -0400 [thread overview]
Message-ID: <4844303E.1040104@hp.com> (raw)
In-Reply-To: <20080603.020734.75959629.yoshfuji@linux-ipv6.org>
YOSHIFUJI Hideaki / 吉藤英明 wrote:
> - if (addr_type == IPV6_ADDR_ANY)
> + addr_type = ipv6_addr_type(&src_info->ipi6_addr);
> + if (addr_type == IPV6_ADDR_ANY ||
> + addr_type & IPV6_ADDR_MULTICAST) {
> + if (dev)
> + dev_put(dev);
> break;
What about link-local multicast? We should check ifindex there too. I
think that check should just be for IPV6_ADDR_ANY. I think making this
more like inet6_bind() and not doing the ipv6_chk_addr() call for
Multicast would be the best thing, right?
-Brian
next prev parent reply other threads:[~2008-06-02 17:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-02 8:12 [PATCH] IPv6: fix bug when specifying the non-exist outgoing interface Shan Wei
2008-06-02 8:20 ` YOSHIFUJI Hideaki / 吉藤英明
2008-06-02 8:52 ` [PATCH v2] " Shan Wei
2008-06-02 8:59 ` Shan Wei
2008-06-02 9:17 ` YOSHIFUJI Hideaki / 吉藤英明
2008-06-02 16:14 ` Brian Haley
2008-06-02 16:26 ` Brian Haley
2008-06-02 16:41 ` YOSHIFUJI Hideaki / 吉藤英明
2008-06-02 16:46 ` YOSHIFUJI Hideaki / 吉藤英明
2008-06-02 16:48 ` YOSHIFUJI Hideaki / 吉藤英明
2008-06-02 17:07 ` YOSHIFUJI Hideaki / 吉藤英明
2008-06-02 17:39 ` Brian Haley [this message]
2008-06-03 4:52 ` YOSHIFUJI Hideaki / 吉藤英明
2008-06-03 7:03 ` Shan Wei
2008-06-03 7:04 ` Shan Wei
2008-06-02 17:39 ` Brian Haley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4844303E.1040104@hp.com \
--to=brian.haley@hp.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=shanwei@cn.fujitsu.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).