From: Jens Gehrlein <sew_s@tqs.de>
To: Steve.Glendinning@smsc.com
Cc: netdev@vger.kernel.org
Subject: Re: [Uclinux-dist-devel] [PATCH 01/01] smsc911x: fix MAC addresssetting after reset
Date: Tue, 03 Jun 2008 12:01:12 +0200 [thread overview]
Message-ID: <48451668.1060407@tqs.de> (raw)
In-Reply-To: <OF35F08D73.56884FA4-ON8025744E.0047900A-8025744E.0047BBC0@smsc.com>
Hi Steve,
Steve.Glendinning@smsc.com schrieb:
>> If the MAC address has been set externally (e. g. by the bootloader
>> or via command line), this setting is lost. This patch fixes the
>> problem by always setting the saved MAC address after soft reset.
Sorry. Newbie question:
How can I pass the MAC address via kernel command line for this driver?
Is there a predefined parameter?
My problem is:
U-Boot resets the chip after each completed transfer. Wolfgang Denk
suggested to pass the MAC address via kernel command line. I need the
ethernet device at kernel startup to mount a root filesystem via NFS, so
I added the platform device in my board specific code as shown below (it
still relates to the old driver).
Should I patch the driver directly to get the MAC address via __setup()
or can I pass the MAC address via the device structures.
What do you suggest?
Thanks and best regards
Jens
--
static struct resource smc911x_resources[] = {
[0] = {
.start = CS4_BASE_ADDR,
.end = CS4_BASE_ADDR + 0xFF,
.flags = IORESOURCE_MEM,
},
[1] = {
.start = MXC_GPIO_BASE + 4,
.end = MXC_GPIO_BASE + 4,
.flags = IORESOURCE_IRQ,
},
};
static struct platform_device smc911x_device = {
.name = "smc911x",
.id = 0,
.num_resources = ARRAY_SIZE(smc911x_resources),
.resource = smc911x_resources,
};
static struct platform_device *myboard_devices[] __initdata = {
&smc911x_device,
};
static int __init <myboard>_devices_setup(void)
{
return platform_add_devices(myboard_devices, ARRAY_SIZE(myboard_devices));
}
device_initcall(myboard_devices_setup);
next prev parent reply other threads:[~2008-06-03 10:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-19 13:03 [Uclinux-dist-devel] [PATCH 01/01] smsc911x: fix MAC addresssetting after reset Steve.Glendinning
2008-06-02 18:38 ` Peter Korsgaard
2008-06-03 10:01 ` Jens Gehrlein [this message]
2008-06-05 9:47 ` Steve.Glendinning
2008-06-05 10:23 ` Jens Gehrlein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48451668.1060407@tqs.de \
--to=sew_s@tqs.de \
--cc=Steve.Glendinning@smsc.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).