From: Patrick McHardy <kaber@trash.net>
To: Jiri Bohac <jbohac@suse.cz>
Cc: netdev@vger.kernel.org, David Miller <davem@davemloft.net>,
Stephen Hemminger <shemminger@linux-foundation.org>,
Jay Vosburgh <fubar@us.ibm.com>
Subject: Re: PATCH: fix bridged 802.3ad bonding
Date: Tue, 03 Jun 2008 16:13:13 +0200 [thread overview]
Message-ID: <48455179.7030503@trash.net> (raw)
In-Reply-To: <20080603132106.GA3256@midget.suse.cz>
Jiri Bohac wrote:
> Hi,
>
> Bonding in 802.3ad mode breaks when the bond interface is added
> to a bridge (which makes 802.3ad unusable in XEN, for example).
>
> The problem is that br_pass_frame_up() will change the skb's dev
> pointer to point to the bridge interface. As a result, the LACP
> packets will not reach the bond_3ad_lacpdu_recv() protocol
> handler registered on the bonding device. Even if they did, the
> handler won't work with the changed skb->dev.
>
> The following patch fixes the problem.
This shouldn't be done in the core code. How about handling this
in either the bridging code or registering the ptype handler for
the briding device?
next prev parent reply other threads:[~2008-06-03 14:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-03 13:21 PATCH: fix bridged 802.3ad bonding Jiri Bohac
2008-06-03 14:13 ` Patrick McHardy [this message]
2008-06-03 16:46 ` Stephen Hemminger
2008-06-03 19:32 ` Jiri Bohac
2008-06-03 20:13 ` Stephen Hemminger
2008-06-03 21:20 ` Jiri Bohac
2008-06-03 21:22 ` Jay Vosburgh
2008-06-03 21:43 ` Stephen Hemminger
2008-06-04 4:55 ` Stephen Hemminger
2008-06-04 8:24 ` Jiri Bohac
2008-06-04 16:06 ` Stephen Hemminger
2008-06-05 10:13 ` Jiri Bohac
2008-06-10 22:42 ` David Miller
2008-06-17 15:33 ` Jiri Bohac
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48455179.7030503@trash.net \
--to=kaber@trash.net \
--cc=davem@davemloft.net \
--cc=fubar@us.ibm.com \
--cc=jbohac@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).