From: James Chapman <jchapman@katalix.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 1/2][L2TP]: Fix possible WARN_ON from socket code when UDP socket is closed
Date: Wed, 04 Jun 2008 23:33:06 +0100 [thread overview]
Message-ID: <48471822.3050202@katalix.com> (raw)
In-Reply-To: <20080604.151146.104754883.davem@davemloft.net>
David Miller wrote:
> From: David Miller <davem@davemloft.net>
> Date: Wed, 04 Jun 2008 15:08:35 -0700 (PDT)
>
>> Applied, thanks.
>
> James your second patch doesn't apply cleanly:
>
> @@ -1066,7 +1100,7 @@ static int pppol2tp_xmit(struct ppp_chan
> dst_release(skb->dst);
> skb->dst = dst_clone(__sk_dst_get(sk_tun));
> skb_orphan(skb);
> - skb->sk = sk_tun;
> + pppol2tp_skb_set_owner_w(skb, sk_tun);
>
> /* Queue the packet to IP for output */
> len = skb->len;
>
> There is no skb_orphan() call in the current pppol2tp.c code.
>
> Please always prepare your patches against the current tree.
My apologies. I sent the wrong patch version. The skb_orphan() call was
moved in the truesize patch that has already been applied. Shall I resend?
--
James Chapman
Katalix Systems Ltd
http://www.katalix.com
Catalysts for your Embedded Linux software development
next prev parent reply other threads:[~2008-06-04 22:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-04 20:56 [PATCH 1/2][L2TP]: Fix possible WARN_ON from socket code when UDP socket is closed James Chapman
2008-06-04 22:08 ` David Miller
2008-06-04 22:11 ` David Miller
2008-06-04 22:33 ` James Chapman [this message]
2008-06-04 22:36 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48471822.3050202@katalix.com \
--to=jchapman@katalix.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).